fix: generated loader template #1720
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -3,9 +3,9 @@ | |||
| * https://webpack.js.org/contribute/writing-a-loader | |||
| */ | |||
|
|
|||
| export default function loader(source) { | |||
| module.exports = function loader(source) { | |||
There was a problem hiding this comment.
I think we should implement --babel option to this in future (put babel config and generate es module syntax)
There was a problem hiding this comment.
Will implement in future PR.
|
Great that we're at this, We should also get back to #1581 with proper handling, @snitin315 can you handle it next? |
Sure 👍🏻 |
anshumanv
previously approved these changes
Aug 1, 2020
alexander-akait
previously approved these changes
Aug 1, 2020
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
shivaylamba
previously approved these changes
Aug 1, 2020
Co-authored-by: James George <jamesgeorge998001@gmail.com>
snitin315
dismissed stale reviews from shivaylamba, alexander-akait, and anshumanv
via
6b2d03b
anshumanv
approved these changes
Aug 2, 2020
jamesgeorge007
approved these changes
Aug 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1719
Does this PR introduce a breaking change?
no
Other information