-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generated loader template #1720
Conversation
@@ -3,9 +3,9 @@ | |||
* https://webpack.js.org/contribute/writing-a-loader | |||
*/ | |||
|
|||
export default function loader(source) { | |||
module.exports = function loader(source) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should implement --babel
option to this in future (put babel config and generate es module syntax)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will implement in future PR.
Great that we're at this, We should also get back to #1581 with proper handling, @snitin315 can you handle it next? |
Sure 👍🏻 |
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
Co-authored-by: James George <jamesgeorge998001@gmail.com>
6b2d03b
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1719
Does this PR introduce a breaking change?
no
Other information