fix: generated plugin template #1717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I think we should create smoke tests for this to avoid this stupid errors 😄 But we can do it in separate PR. Test is not hard to write:
- Run generate plugin
- Inject plugin to webpack, plugin can be simple, for example write
console.log('Works') - Check it on stdout
alexander-akait
approved these changes
Jul 31, 2020
|
CI is not working 😞 |
alexander-akait
approved these changes
Aug 1, 2020
|
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
anshumanv
approved these changes
Aug 1, 2020
jamesgeorge007
approved these changes
Aug 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NA
Summary
Fixes #1623, the closing brace (
}) was missing.Does this PR introduce a breaking change?
No
Other information