-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: generated plugin template #1717
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create smoke tests for this to avoid this stupid errors 😄 But we can do it in separate PR. Test is not hard to write:
- Run generate plugin
- Inject plugin to webpack, plugin can be simple, for example write
console.log('Works')
- Check it on stdout
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's do same test for loader
CI is not working 😞 |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NA
Summary
Fixes #1623, the closing brace (
}
) was missing.Does this PR introduce a breaking change?
No
Other information