-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[utils]: opt to use config schema from core #1655
Conversation
Unusual test failing, taking a look |
@anshumanv yep, can you look why sometime tests failed? |
@evilebottnawi I checked and it seems the error is specific to this PR(different from random failures) - Though I'm not sure why would everything break due to this change, runs fine locally. |
@anshumanv yep, very strange |
@webpack/cli-team need small help, can you guys take a look at this? Unable to figure out. |
for webpack@4 config is undefined -for webpack@5 |
Need add check |
Ah yes got it, thanks for looking @snitin315 @evilebottnawi 👍 |
@evilebottnawi @snitin315 review ready 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect 💯
What kind of change does this PR introduce?
cleanup
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information