-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for none config in dotfolder #1637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests where we have multiple configuration and load them based on mode
?
Config resolves doesn't respect mode, will add the support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create test where we have
.webpack/webpack.config.developmen.js
webpack.config.developmen.js
webpack.config.js
We need test what we load the right configuration
Yes, in near future @evilebottnawi 👍 |
@evilebottnawi added 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So we prefer webpack.config.develoment.js
over .webpack/webpack.config.development.js
?
Yes |
@webpack/cli-team we need small discussion about it, should we prefer config from |
|
Seems fair |
Updated |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information
No