-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): import flags from webpack core #1630
Conversation
5952f55
to
277b765
Compare
fd22f7d
to
f8d3248
Compare
list of broken flags -
|
9248125
to
6c52f32
Compare
Draft list of flags we can drop ( need discussion ) -
|
I'm not sure of the feasibility of removing this on the core, should we keep a list of unsupported flags and remove them after importing core flags? |
Yes, I think we can filter flags on the CLI side. |
|
Not sure we should support it, because we have
What we should use? I don't know, so better:
|
@evilebottnawi I think we can specify |
@snitin315 For all (not sure for all but for most of them) |
Let's implement |
c8508ef
to
138253d
Compare
@snitin315 Can we move these changes:
to other PRs, to avoid unnecessary changes in this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯
a006725
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
@jamesgeorge007 please don't commit yourself, suggestions suffice |
a006725
to
1b9f555
Compare
@webpack/cli-team Merge? |
yep we can merge 👍 |
Big thanks for all, it is great feature, I think we should resolve |
What kind of change does this PR introduce?
Feature.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Follow up #1629
Refers #717
Closes #1241
Does this PR introduce a breaking change?
Other information
TODO
--no-name
negated flags.string
for every flag )