-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): allow multiple entry files #1619
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not implement --multiple-flag
, we should allow to run
webpack src/one.js src/two.js src/three.js
@evilebottnawi we can do this for entry but what about other flags that can take multiple values? |
@snitin315 Let's start with entry, it is most popular use case |
c853f44
to
a061b83
Compare
a061b83
to
c261aa4
Compare
6628137
to
45c5188
Compare
45c5188
to
5a74566
Compare
Ready for review 🙌 |
/cc @webpack/cli-team |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @rishabh3112
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
Hey lads. What about named entries? Webpack 4 allowed passing |
Confirming this is broken now in webpack-cli. You cannot define an entry's name in the cli, preventing different compiled file names than entry file names, where this is possible in webpack config. |
What kind of change does this PR introduce?
Feature
Did you add tests for your changes?
YES
If relevant, did you update the documentation?
YES
Summary
Now we can provide multiple entry files via CLI using -
webpack --entry=a.js --entry=b.js
webpack ./a.js ./b.js
Refers #717
Fixes #1454
Does this PR introduce a breaking change?
Other information