Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow only specified negated flags #1613

Merged
merged 2 commits into from
Jun 7, 2020

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
YES
If relevant, did you update the documentation?
NA
Summary
CLI will support only specific negated flags

Does this PR introduce a breaking change?
Maybe

Other information

@snitin315 snitin315 requested a review from a team as a code owner June 4, 2020 15:37
@snitin315 snitin315 closed this Jun 4, 2020
@snitin315 snitin315 reopened this Jun 4, 2020
@snitin315
Copy link
Member Author

/cc @webpack/cli-team

@snitin315 snitin315 force-pushed the feat/specific-negated-flags branch from 4af3ae3 to b5ce268 Compare June 5, 2020 02:55
@snitin315 snitin315 force-pushed the feat/specific-negated-flags branch from b5ce268 to 1553c46 Compare June 5, 2020 02:56
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@snitin315
Copy link
Member Author

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evenstensberg Please review the new changes.

@alexander-akait alexander-akait merged commit 885e0a2 into webpack:next Jun 7, 2020
@snitin315 snitin315 deleted the feat/specific-negated-flags branch June 7, 2020 15:42
@snitin315 snitin315 added this to Done in GSoC 2020 Jul 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
GSoC 2020
  
Done (Phase 1)
Development

Successfully merging this pull request may close these issues.

None yet

4 participants