Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 🎸 add support for env flag #1598

Merged
merged 5 commits into from
Jun 5, 2020
Merged

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
Yet to

Summary

  • Add support for --env flag back.

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv marked this pull request as ready for review May 30, 2020 10:23
@anshumanv anshumanv requested a review from a team as a code owner May 30, 2020 10:23
snitin315
snitin315 previously approved these changes Jun 1, 2020
shivaylamba
shivaylamba previously approved these changes Jun 1, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have docs about supported configurations? Like function/Promise/etc

@anshumanv
Copy link
Member Author

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's rename is to mode to avoid misleading between configuration and flags for CLI (also we already have mode flag)

@alexander-akait
Copy link
Member

I was wrong, give me time to think

@alexander-akait
Copy link
Member

I would like to avoid this because this is very misleading, Maybe we should just pass argv, without env flag (normalize them before)

@alexander-akait
Copy link
Member

What is really diffidence between env and argv? I see no difference, just pass flags in difference ways

@anshumanv
Copy link
Member Author

argv has other things too, env is only what passed to the configuration function.

@alexander-akait
Copy link
Member

@anshumanv Alright, let's get this back for compatibility, but we will need to throw depications in the future and pass only args + normalized args

@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@anshumanv anshumanv merged commit 7249153 into webpack:next Jun 5, 2020
@anshumanv anshumanv deleted the feat/env branch June 5, 2020 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants