-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 🎸 add support for env flag #1598
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have docs about supported configurations? Like function
/Promise
/etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to add this flag in docs as well https://github.com/webpack/webpack-cli/tree/next/packages/webpack-cli#webpack-cli
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename is to mode
to avoid misleading between configuration and flags for CLI (also we already have mode
flag)
I was wrong, give me time to think |
I would like to avoid this because this is very misleading, Maybe we should just pass |
What is really diffidence between |
argv has other things too, env is only what passed to the configuration function. |
@anshumanv Alright, let's get this back for compatibility, but we will need to throw depications in the future and pass only |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @snitin315 Please review the new changes. |
What kind of change does this PR introduce?
feat
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yet to
Summary
Does this PR introduce a breaking change?
No
Other information