fix: 🐛 do not apply own defaults while setting mode #1565
Conversation
|
Adding in a while |
|
@evilebottnawi added 👍 |
| @@ -40,6 +41,8 @@ describe('GroupHelper', function () { | |||
| ]); | |||
|
|
|||
| const result = group.run(); | |||
| // ensure no other properties are added | |||
| expect(result.options).toMatchObject({ mode: 'development' }); | |||
There was a problem hiding this comment.
Can we look on plugins here?
There was a problem hiding this comment.
Old method is only adding config options from the file and no plugins
There was a problem hiding this comment.
We should look what we don't have two terser plugins here
There was a problem hiding this comment.
Can you suggest ways to check it here? We're just passing mode to the compiler, so since core doesn't have two, we won't have two either.
There was a problem hiding this comment.
Hm, maybe we can add a test there manually added Terser to minimizer with custom options, for commentsFilename, not the best solution, but will be work
There was a problem hiding this comment.
Added, something wrong with CI, will take a look tomm
There was a problem hiding this comment.
@evilebottnawi seems good now, PTAL
|
Need look at CI, idk what's failing |
|
@evilebottnawi fixed now, had to do some changes to the install script since it was running into race condition. Looks all good now. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Does this PR introduce a breaking change?
No
Other information