-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-cli): verbose flag functionality #1549
Conversation
fae35b3
to
107ae2c
Compare
e01fd20
to
1edf00f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
/cc @rishabh3112 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Need to have a better test here.
const { run } = require('../utils/test-utils'); | ||
|
||
describe('verbose flag', () => { | ||
it('should accept --verbose', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need a better test here. i.e. we should test for lines in stdout that are found only in verbose stats.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated 👍, Please take a look.
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
What kind of change does this PR introduce?
fixes verbose flag implementation.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1542
After
Does this PR introduce a breaking change?
No
Other information