Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack-cli): verbose flag functionality #1549

Merged
merged 1 commit into from
May 21, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented May 16, 2020

What kind of change does this PR introduce?
fixes verbose flag implementation.

Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Fixes #1542

After

Screenshot at 2020-05-18 11-45-54

Does this PR introduce a breaking change?
No

Other information

@snitin315 snitin315 force-pushed the fix/verbose branch 2 times, most recently from fae35b3 to 107ae2c Compare May 16, 2020 13:40
@snitin315 snitin315 closed this May 17, 2020
@snitin315 snitin315 reopened this May 17, 2020
@snitin315 snitin315 force-pushed the fix/verbose branch 4 times, most recently from e01fd20 to 1edf00f Compare May 18, 2020 05:38
@snitin315 snitin315 changed the title fix: verbose flag functionality fix(webpack-cli): verbose flag functionality May 18, 2020
@snitin315 snitin315 marked this pull request as ready for review May 18, 2020 05:59
@snitin315 snitin315 requested a review from a team as a code owner May 18, 2020 05:59
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@snitin315
Copy link
Member Author

/cc @rishabh3112

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Need to have a better test here.

const { run } = require('../utils/test-utils');

describe('verbose flag', () => {
it('should accept --verbose', () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need a better test here. i.e. we should test for lines in stdout that are found only in verbose stats.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated 👍, Please take a look.

@webpack-bot
Copy link

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@snitin315 snitin315 reopened this May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: --verbose is not working
6 participants