tests: add tests for project root finder util

[anshumanv]

What kind of change does this PR introduce?
Test

Did you add tests for your changes?
Yes

If relevant, did you update the documentation?
NA

Summary

• Add tests for project root finder util
• Closes [test]: Add tests for utils to find project root #967

Does this PR introduce a breaking change?
No

Other information
Any suggestions are appreciated.

[anshumanv]

@rishabh3112 init tests seem to fail for some reason, when I was debugging it yesterday it seems that we're checking yarn.lock file too soon before it's created. You can follow - #1478

[rishabh3112]

@anshumanv the reason you specified isn't possible as currently runPromptWithAnswers didn't exit the process until it exit on it's own. So, it should be there if this has to be there after it exits.

You may add debug logs to check which files are created while we are testing the existance of yarn.lock ( may be npm is being used during installation and package-lock.json created instead ).

[anshumanv]

You may add debug logs to check which files are created while we are testing the existance of yarn.lock ( may be npm is being used during installation and package-lock.json created instead ).

Already did in plugin PR, yarn.lock wasn't found and no package-lock wasn't created either, I think there's some IO gap in the time it takes to write the file on disk and we may be checking before that.

[anshumanv]

This is happening in several PRs, you can check those too

[anshumanv]

For example check here - #1480 @rishabh3112

[rishabh3112]

Already did in plugin PR, yarn.lock wasn't found and no package-lock wasn't created either, I think there's some IO gap in the time it takes to write the file on disk and we may be checking before that.

That is only possible if yarn exits its install process without waiting for yarn.lock file to be created. Is that the case?

Anyway, to find actual reason,
Try debug logging before tests to find the exact reason.

• Use fs.readdir for looking at files being created in macos container. (As test fail at macos only).
• This could also be possible that some error was encountered and process ended in between, so try logging stdout too to check if thats the case.
• Look at the commits being added to next branch that change the behavior of runInitWithAnswers after I added these tests. As init tests were passing in CI at that point of time.

Hope this helps :)

[anshumanv]

That is only possible if yarn exits its install process without waiting for yarn.lock file to be created. Is that the case?

Anyway, to find actual reason, Try debug logging before tests to find the exact reason.

Did all of that already at #1478

This could also be possible that some error was encountered and process ended in between, so try logging stdout too to check if thats the case.

The process completes, no issue with process, once you remove yarn.lock from tests, it passes which is strange and led me to conclude that it's an IO problem, 😕

Look at the commits being added to next branch that change the behavior of runInitWithAnswers after I added these tests. As init tests were passing in CI at that point of time.

No major changes

[alexander-akait]

CI still broken 😞

[anshumanv]

Checking @evilebottnawi 😄

[anshumanv]

/cc @evilebottnawi