fix(webpack-cli): throw error for invalid args #1462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rishabh3112
requested changes
Apr 15, 2020
snitin315
force-pushed
the
fix/help-group
branch
from
9cedde5
to
6da6aa9
Compare
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
snitin315
force-pushed
the
fix/help-group
branch
from
5c9cf2a
to
c665c01
Compare
snitin315
force-pushed
the
fix/help-group
branch
from
c665c01
to
3a05fca
Compare
snitin315
force-pushed
the
fix/help-group
branch
2 times, most recently
from
13d9067
to
8fbf100
Compare
snitin315
force-pushed
the
fix/help-group
branch
3 times, most recently
from
c8ce7aa
to
ffc896b
Compare
alexander-akait
previously approved these changes
Apr 16, 2020
webpack-bot
added
PR: reviewed-approved
PR: review-outdated
and removed
PR: review-outdated
PR: reviewed-approved
labels
snitin315
force-pushed
the
fix/help-group
branch
3 times, most recently
from
a35ad8c
to
a346435
Compare
|
Friendly ping @rishabh3112 |
rishabh3112
previously approved these changes
Apr 29, 2020
|
CI is green 😄 |
|
/cc @jamesgeorge007 |
snitin315
force-pushed
the
fix/help-group
branch
from
9b78c6d
to
1fb9241
Compare
|
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
Signed-off-by: Nitin Kumar <snitin315@gmail.com>
snitin315
force-pushed
the
fix/help-group
branch
from
1fb9241
to
f1aa38c
Compare
jamesgeorge007
approved these changes
Apr 29, 2020
rishabh3112
approved these changes
Apr 30, 2020
snitin315
changed the title
This was referenced Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug Fix
Fixes #1412
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Now cli throws an error if invalid args are passed with
versionorhelp.Does this PR introduce a breaking change?
Maybe
Other information