-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-cli): throw error for invalid args #1462
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be changed for help
command in context to DX imo.
We should display help
anyway (as user wants help) and a warning should be displayed for passing invalid option.
9cedde5
to
6da6aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Read comments
5c9cf2a
to
c665c01
Compare
c665c01
to
3a05fca
Compare
13d9067
to
8fbf100
Compare
c8ce7aa
to
ffc896b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team
a35ad8c
to
a346435
Compare
Friendly ping @rishabh3112 |
CI is green 😄 |
/cc @jamesgeorge007 |
9b78c6d
to
1fb9241
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
Signed-off-by: Nitin Kumar <snitin315@gmail.com>
1fb9241
to
f1aa38c
Compare
What kind of change does this PR introduce?
Bug Fix
Fixes #1412
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Now cli throws an error if invalid args are passed with
version
orhelp
.Does this PR introduce a breaking change?
Maybe
Other information