Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack-cli): --version for external packages #1421

Merged
merged 5 commits into from
Apr 13, 2020

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Apr 5, 2020

What kind of change does this PR introduce?
Feature.
Now cli is able to shoe version of external packages as well.
Fixes #1363

Did you add tests for your changes?

YES

If relevant, did you update the documentation?

YES

Summary

Screenshot from 2020-04-05 17-48-05

Does this PR introduce a breaking change?

Maybe

Other information

@snitin315 snitin315 force-pushed the version branch 4 times, most recently from 92434be to 82b1bda Compare April 5, 2020 15:28
@snitin315 snitin315 marked this pull request as ready for review April 5, 2020 15:44
@snitin315 snitin315 requested a review from a team as a code owner April 5, 2020 15:44
@snitin315 snitin315 closed this Apr 5, 2020
@snitin315 snitin315 reopened this Apr 5, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One fix

jamesgeorge007
jamesgeorge007 previously approved these changes Apr 11, 2020
Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@anshumanv anshumanv merged commit 756a8ff into webpack:next Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FEATURE: --version for sub packages
6 participants