-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(generators): fix small issues with generators #1385
fix(generators): fix small issues with generators #1385
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good mostly.
fc17a6f
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
0ac4069
to
11d751c
Compare
fb925b1
to
11d751c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please resolve the conflicts.
11d751c
to
ee45262
Compare
@evilebottnawi Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
@evilebottnawi The tests look fine, but there are code style issue in your Pull Request. Please review the following:
See complete report here. |
Seems to be a bad test run |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
@Loonride ignore it, we migrate on github actions |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Not yet
If relevant, did you update the documentation?
N/A
Summary
sw.js
use correct template path for init generatorEdit:
init-generator
testsaddon-generator
testsentryOption
property forinit-generator
becausewebpackOptions.entry
is not always set in the init generator if the user wants the default entry value, so the value of that variable cannot be relied upon later on in the generatorDoes this PR introduce a breaking change?
Yes, some slight breaking changes
Other information