fix(generators): fix small issues with generators #1385

knagaitsev · 2020-03-27T03:57:30Z

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
Not yet

If relevant, did you update the documentation?
N/A

Summary

made sw.js use correct template path for init generator
made mkdirp sync, it seems problematic that it was async before since we never know when the folder is created
removed use of this.async() for the yeoman generator, I think this is an old thing that is not needed anymore with new yeoman version
make generator choose between yarn and npm

Edit:

more init-generator tests
addon-generator tests
created entryOption property for init-generator because webpackOptions.entry is not always set in the init generator if the user wants the default entry value, so the value of that variable cannot be relied upon later on in the generator
added rimraf dependency globally (it seems it was supposed to be there because a script uses it)

Does this PR introduce a breaking change?
Yes, some slight breaking changes

Other information

packages/generators/src/addon-generator.ts

anshumanv

Looks good mostly.

packages/generators/src/addon-generator.ts

packages/generators/src/init-generator.ts

alexander-akait

Thanks!

jamesgeorge007

Please resolve the conflicts.

webpack-bot · 2020-03-31T15:56:17Z

@evilebottnawi Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@jamesgeorge007 Please review the new changes.

webpack-bot · 2020-03-31T16:03:08Z

@evilebottnawi The tests look fine, but there are code style issue in your Pull Request. Please review the following:

Worker information [...]
Build system information [...]
travis_fold:start:docker_mtu
travis_fold:end:docker_mtu
travis_fold:start:resolvconf
travis_fold:end:resolvconf


Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions

Setting environment variables from repository settings
$ export nproc=4

Setting environment variables from .travis.yml
$ export JOB_PART=lint


Setting up build cache [...]
 [...]
$ node --version
v12.16.1
$ npm --version
6.13.4
$ nvm --version
0.35.3
$ yarn --version
1.15.2

$ yarn travis:lint
�[2K�[1Gyarn run v1.22.4
�[2K�[1Gerror Command "travis:lint" not found.
�[2K�[1Ginfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn travis:lint" exited with 1.
$ yarn test:ci
�[2K�[1Gyarn run v1.22.4
�[2K�[1G$ yarn test:cli && yarn test:packages
�[2K�[1G$ jest test/ --reporters=default --reporters=jest-junit --forceExit
 PASS  test/node/node.test.js
 PASS  test/mode/prod/prod.test.js
 PASS  test/global/global.test.js (5.13s)
 PASS  test/no-mode/no-mode.test.js
 PASS  test/output/named-bundles/output-named-bundles.test.js
 PASS  test/utils/test-utils.test.js
 PASS  test/info/info-help.test.js
 FAIL  test/serve/serve-basic.test.js
  ● basic serve usage › compiles without flags

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      35 |         it('compiles without flags', async () => {
      36 |             const { stdout, stderr } = await runServe(['--port', port]);
    > 37 |             expect(stdout).toContain('main.js');
         |                            ^
      38 |             expect(stdout).not.toContain('hot/dev-server.js');
      39 |             expect(stderr).toHaveLength(0);
      40 |         });

      at Object.<anonymous> (test/serve/serve-basic.test.js:37:28)

  ● basic serve usage › uses hot flag to alter bundle

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      42 |         it('uses hot flag to alter bundle', async () => {
      43 |             const { stdout, stderr } = await runServe(['--port', port, '--hot']);
    > 44 |             expect(stdout).toContain('main.js');
         |                            ^
      45 |             expect(stdout).toContain('hot/dev-server.js');
      46 |             expect(stderr).toHaveLength(0);
      47 |         });

      at Object.<anonymous> (test/serve/serve-basic.test.js:44:28)

  ● basic serve usage › uses hot flag and progress flag

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      49 |         it('uses hot flag and progress flag', async () => {
      50 |             const { stdout, stderr } = await runServe(['--port', port, '--hot', '--progress']);
    > 51 |             expect(stdout).toContain('main.js');
         |                            ^
      52 |             expect(stdout).toContain('hot/dev-server.js');
      53 |             // progress flag makes use of stderr
      54 |             expect(stderr).not.toHaveLength(0);

      at Object.<anonymous> (test/serve/serve-basic.test.js:51:28)

  ● basic serve usage › throws error on unknown flag

    expect(received).toContain(expected) // indexOf

    Expected substring: "Unknown option: --unknown-flag"
    Received string:    "[webpack-cli] Promise rejection: Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
    [webpack-cli] Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
        at tryPackage (internal/modules/cjs/loader.js:316:19)
        at Function.Module._findPath (internal/modules/cjs/loader.js:705:18)
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:969:27)
        at Function.Module._load (internal/modules/cjs/loader.js:864:27)
        at Module.require (internal/modules/cjs/loader.js:1044:19)
        at require (internal/modules/cjs/helpers.js:77:18)
        at Object.<anonymous> (/home/travis/build/webpack/webpack-cli/packages/webpack-cli/lib/commands/ExternalCommand.js:4:47)
        at Module._compile (internal/modules/cjs/loader.js:1158:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
        at Module.load (internal/modules/cjs/loader.js:1002:32)"

      58 |             const { stdout, stderr } = await runServe(['--port', port, '--unknown-flag']);
      59 |             expect(stdout).toHaveLength(0);
    > 60 |             expect(stderr).toContain('Unknown option: --unknown-flag');
         |                            ^
      61 |         });
      62 |     }
      63 | });

      at Object.<anonymous> (test/serve/serve-basic.test.js:60:28)

 PASS  test/stats/stats.test.js (10.273s)
 PASS  test/mode/dev/dev.test.js
 PASS  test/version/version-multi-args.test.js
 PASS  test/help/help-single-arg.test.js
 PASS  test/defaults/output-defaults.test.js
 FAIL  test/info/info-output.test.js
  ● basic info usage › gets info without flags

    expect(received).toContain(expected) // indexOf

    Expected substring: "System:"
    Received string:    ""

      14 |         // stdout should include many details which will be
      15 |         // unique for each computer
    > 16 |         expect(stdout).toContain('System:');
         |                        ^
      17 |         expect(stderr).toHaveLength(0);
      18 |     });
      19 | 

      at Object.<anonymous> (test/info/info-output.test.js:16:24)

  ● basic info usage › gets info as json

    expect(received).toContain(expected) // indexOf

    Expected substring: "\"System\":"
    Received string:    ""

      20 |     it('gets info as json', async () => {
      21 |         const { stdout, stderr } = await runInfo(['--output-json']);
    > 22 |         expect(stdout).toContain('"System":');
         |                        ^
      23 |         expect(stderr).toHaveLength(0);
      24 | 
      25 |         const parse = () => {

      at Object.<anonymous> (test/info/info-output.test.js:22:24)

  ● basic info usage › gets info as markdown

    expect(received).toContain(expected) // indexOf

    Expected substring: "## System:"
    Received string:    ""

      32 |     it('gets info as markdown', async () => {
      33 |         const { stdout, stderr } = await runInfo(['--output-markdown']);
    > 34 |         expect(stdout).toContain('## System:');
         |                        ^
      35 |         expect(stderr).toHaveLength(0);
      36 |     });
      37 | 

      at Object.<anonymous> (test/info/info-output.test.js:34:24)

  ● basic info usage › gets only specific info

    expect(received).toContain(expected) // indexOf

    Expected substring: "## Binaries:"
    Received string:    ""

      40 |         // system info is not specified as a flag
      41 |         expect(stdout).not.toContain('## System:');
    > 42 |         expect(stdout).toContain('## Binaries:');
         |                        ^
      43 |         expect(stderr).toHaveLength(0);
      44 |     });
      45 | });

      at Object.<anonymous> (test/info/info-output.test.js:42:24)

 FAIL  test/info/info-multi-args.test.js
  ● info with multiple flags › gets info about system and browser

    expect(received).toContain(expected) // indexOf

    Expected substring: "System:"
    Received string:    ""

      12 |     it('gets info about system and browser', async () => {
      13 |         const { stdout, stderr } = await runInfo(['--system', '--binaries']);
    > 14 |         expect(stdout).toContain('System:');
         |                        ^
      15 |         expect(stdout).toContain('Binaries:');
      16 |         expect(stderr).toHaveLength(0);
      17 |     });

      at Object.<anonymous> (test/info/info-multi-args.test.js:14:24)

  ● info with multiple flags › gets only system info as json

    expect(received).toContain(expected) // indexOf

    Expected substring: "\"System\":"
    Received string:    ""

      19 |     it('gets only system info as json', async () => {
      20 |         const { stdout, stderr } = await runInfo(['-s', '--output-json']);
    > 21 |         expect(stdout).toContain('"System":');
         |                        ^
      22 |         expect(stderr).toHaveLength(0);
      23 |         const parse = () => {
      24 |             JSON.parse(stdout);

      at Object.<anonymous> (test/info/info-multi-args.test.js:21:24)

  ● info with multiple flags › gets only binary info in markdown

    expect(received).toContain(expected) // indexOf

    Expected substring: "## Binaries:"
    Received string:    ""

      30 |     it('gets only binary info in markdown', async () => {
      31 |         const { stdout, stderr } = await runInfo(['-b', '--output-markdown']);
    > 32 |         expect(stdout).toContain('## Binaries:');
         |                        ^
      33 |         expect(stdout).not.toContain('## System:');
      34 |         expect(stderr).toHaveLength(0);
      35 |     });

      at Object.<anonymous> (test/info/info-multi-args.test.js:32:24)

  ● info with multiple flags › gets npm packages

    expect(received).toHaveLength(expected)

    Expected length: 0
    Received length: 1135
    Received string: "[webpack-cli] Promise rejection: Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
    [webpack-cli] Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
        at tryPackage (internal/modules/cjs/loader.js:316:19)
        at Function.Module._findPath (internal/modules/cjs/loader.js:705:18)
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:969:27)
        at Function.Module._load (internal/modules/cjs/loader.js:864:27)
        at Module.require (internal/modules/cjs/loader.js:1044:19)
        at require (internal/modules/cjs/helpers.js:77:18)
        at Object.<anonymous> (/home/travis/build/webpack/webpack-cli/packages/webpack-cli/lib/commands/ExternalCommand.js:4:47)
        at Module._compile (internal/modules/cjs/loader.js:1158:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
        at Module.load (internal/modules/cjs/loader.js:1002:32)"

      37 |     it('gets npm packages', async () => {
      38 |         const { stderr } = await runInfo(['--npmg', '--npmPackages']);
    > 39 |         expect(stderr).toHaveLength(0);
         |                        ^
      40 |     });
      41 | });
      42 | 

      at Object.<anonymous> (test/info/info-multi-args.test.js:39:24)

 PASS  test/source-map/object/source-map-object.test.js
 PASS  test/help/help-flags.test.js
 PASS  test/help/help-commands.test.js
 PASS  test/merge/defaults/merge-defaults.test.js
 PASS  test/help/help-multi-args.test.js
 PASS  test/env/prod/prod.test.js
 PASS  test/entry/defaults-index/entry-multi-args.test.js
 PASS  test/env/array/array-env.test.js
 PASS  test/source-map/array/source-map-array.test.js
 PASS  test/typescript/typescript.test.js
 PASS  test/env/object/object-env.test.js
 PASS  test/config-lookup/dotfolder-array/dotfolder-array.test.js
 PASS  test/config/basic/basic-config.test.js
 PASS  test/config/type/array/array-config.test.js
 PASS  test/config-lookup/dotfolder-single/dotfolder-single.test.js
 PASS  test/merge/config/merge-config.test.js
 PASS  test/entry/config-entry/entry-with-command/entry-with-command.test.js
 PASS  test/version/version-single-arg.test.js
 PASS  test/defaults/without-config-and-entry/default-without-config.test.js
 PASS  test/entry/config-entry/entry-with-config/entry-with-config.test.js
 PASS  test/config/type/function/function-config.test.js
 PASS  test/target/node/node-test.test.js
 PASS  test/entry/scss/scss.test.js
 PASS  test/standard/standard.test.js
 PASS  test/config/empty/empty-config.test.js
 PASS  test/entry/defaults-empty/entry-single-arg.test.js
 PASS  test/unknown/unknown.test.js
�[999D�[K
Summary of all failing tests
 FAIL  test/serve/serve-basic.test.js
  ● basic serve usage › compiles without flags

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      35 |         it('compiles without flags', async () => {
      36 |             const { stdout, stderr } = await runServe(['--port', port]);
    > 37 |             expect(stdout).toContain('main.js');
         |                            ^
      38 |             expect(stdout).not.toContain('hot/dev-server.js');
      39 |             expect(stderr).toHaveLength(0);
      40 |         });

      at Object.<anonymous> (test/serve/serve-basic.test.js:37:28)

  ● basic serve usage › uses hot flag to alter bundle

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      42 |         it('uses hot flag to alter bundle', async () => {
      43 |             const { stdout, stderr } = await runServe(['--port', port, '--hot']);
    > 44 |             expect(stdout).toContain('main.js');
         |                            ^
      45 |             expect(stdout).toContain('hot/dev-server.js');
      46 |             expect(stderr).toHaveLength(0);
      47 |         });

      at Object.<anonymous> (test/serve/serve-basic.test.js:44:28)

  ● basic serve usage › uses hot flag and progress flag

    expect(received).toContain(expected) // indexOf

    Expected substring: "main.js"
    Received string:    ""

      49 |         it('uses hot flag and progress flag', async () => {
      50 |             const { stdout, stderr } = await runServe(['--port', port, '--hot', '--progress']);
    > 51 |             expect(stdout).toContain('main.js');
         |                            ^
      52 |             expect(stdout).toContain('hot/dev-server.js');
      53 |             // progress flag makes use of stderr
      54 |             expect(stderr).not.toHaveLength(0);

      at Object.<anonymous> (test/serve/serve-basic.test.js:51:28)

  ● basic serve usage › throws error on unknown flag

    expect(received).toContain(expected) // indexOf

    Expected substring: "Unknown option: --unknown-flag"
    Received string:    "[webpack-cli] Promise rejection: Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
    [webpack-cli] Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
        at tryPackage (internal/modules/cjs/loader.js:316:19)
        at Function.Module._findPath (internal/modules/cjs/loader.js:705:18)
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:969:27)
        at Function.Module._load (internal/modules/cjs/loader.js:864:27)
        at Module.require (internal/modules/cjs/loader.js:1044:19)
        at require (internal/modules/cjs/helpers.js:77:18)
        at Object.<anonymous> (/home/travis/build/webpack/webpack-cli/packages/webpack-cli/lib/commands/ExternalCommand.js:4:47)
        at Module._compile (internal/modules/cjs/loader.js:1158:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
        at Module.load (internal/modules/cjs/loader.js:1002:32)"

      58 |             const { stdout, stderr } = await runServe(['--port', port, '--unknown-flag']);
      59 |             expect(stdout).toHaveLength(0);
    > 60 |             expect(stderr).toContain('Unknown option: --unknown-flag');
         |                            ^
      61 |         });
      62 |     }
      63 | });

      at Object.<anonymous> (test/serve/serve-basic.test.js:60:28)

 FAIL  test/info/info-output.test.js
  ● basic info usage › gets info without flags

    expect(received).toContain(expected) // indexOf

    Expected substring: "System:"
    Received string:    ""

      14 |         // stdout should include many details which will be
      15 |         // unique for each computer
    > 16 |         expect(stdout).toContain('System:');
         |                        ^
      17 |         expect(stderr).toHaveLength(0);
      18 |     });
      19 | 

      at Object.<anonymous> (test/info/info-output.test.js:16:24)

  ● basic info usage › gets info as json

    expect(received).toContain(expected) // indexOf

    Expected substring: "\"System\":"
    Received string:    ""

      20 |     it('gets info as json', async () => {
      21 |         const { stdout, stderr } = await runInfo(['--output-json']);
    > 22 |         expect(stdout).toContain('"System":');
         |                        ^
      23 |         expect(stderr).toHaveLength(0);
      24 | 
      25 |         const parse = () => {

      at Object.<anonymous> (test/info/info-output.test.js:22:24)

  ● basic info usage › gets info as markdown

    expect(received).toContain(expected) // indexOf

    Expected substring: "## System:"
    Received string:    ""

      32 |     it('gets info as markdown', async () => {
      33 |         const { stdout, stderr } = await runInfo(['--output-markdown']);
    > 34 |         expect(stdout).toContain('## System:');
         |                        ^
      35 |         expect(stderr).toHaveLength(0);
      36 |     });
      37 | 

      at Object.<anonymous> (test/info/info-output.test.js:34:24)

  ● basic info usage › gets only specific info

    expect(received).toContain(expected) // indexOf

    Expected substring: "## Binaries:"
    Received string:    ""

      40 |         // system info is not specified as a flag
      41 |         expect(stdout).not.toContain('## System:');
    > 42 |         expect(stdout).toContain('## Binaries:');
         |                        ^
      43 |         expect(stderr).toHaveLength(0);
      44 |     });
      45 | });

      at Object.<anonymous> (test/info/info-output.test.js:42:24)

 FAIL  test/info/info-multi-args.test.js
  ● info with multiple flags › gets info about system and browser

    expect(received).toContain(expected) // indexOf

    Expected substring: "System:"
    Received string:    ""

      12 |     it('gets info about system and browser', async () => {
      13 |         const { stdout, stderr } = await runInfo(['--system', '--binaries']);
    > 14 |         expect(stdout).toContain('System:');
         |                        ^
      15 |         expect(stdout).toContain('Binaries:');
      16 |         expect(stderr).toHaveLength(0);
      17 |     });

      at Object.<anonymous> (test/info/info-multi-args.test.js:14:24)

  ● info with multiple flags › gets only system info as json

    expect(received).toContain(expected) // indexOf

    Expected substring: "\"System\":"
    Received string:    ""

      19 |     it('gets only system info as json', async () => {
      20 |         const { stdout, stderr } = await runInfo(['-s', '--output-json']);
    > 21 |         expect(stdout).toContain('"System":');
         |                        ^
      22 |         expect(stderr).toHaveLength(0);
      23 |         const parse = () => {
      24 |             JSON.parse(stdout);

      at Object.<anonymous> (test/info/info-multi-args.test.js:21:24)

  ● info with multiple flags › gets only binary info in markdown

    expect(received).toContain(expected) // indexOf

    Expected substring: "## Binaries:"
    Received string:    ""

      30 |     it('gets only binary info in markdown', async () => {
      31 |         const { stdout, stderr } = await runInfo(['-b', '--output-markdown']);
    > 32 |         expect(stdout).toContain('## Binaries:');
         |                        ^
      33 |         expect(stdout).not.toContain('## System:');
      34 |         expect(stderr).toHaveLength(0);
      35 |     });

      at Object.<anonymous> (test/info/info-multi-args.test.js:32:24)

  ● info with multiple flags › gets npm packages

    expect(received).toHaveLength(expected)

    Expected length: 0
    Received length: 1135
    Received string: "[webpack-cli] Promise rejection: Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
    [webpack-cli] Error: Cannot find module '/home/travis/build/webpack/webpack-cli/node_modules/@webpack-cli/package-utils/lib/index.js'. Please verify that the package.json has a valid \"main\" entry
        at tryPackage (internal/modules/cjs/loader.js:316:19)
        at Function.Module._findPath (internal/modules/cjs/loader.js:705:18)
        at Function.Module._resolveFilename (internal/modules/cjs/loader.js:969:27)
        at Function.Module._load (internal/modules/cjs/loader.js:864:27)
        at Module.require (internal/modules/cjs/loader.js:1044:19)
        at require (internal/modules/cjs/helpers.js:77:18)
        at Object.<anonymous> (/home/travis/build/webpack/webpack-cli/packages/webpack-cli/lib/commands/ExternalCommand.js:4:47)
        at Module._compile (internal/modules/cjs/loader.js:1158:30)
        at Object.Module._extensions..js (internal/modules/cjs/loader.js:1178:10)
        at Module.load (internal/modules/cjs/loader.js:1002:32)"

      37 |     it('gets npm packages', async () => {
      38 |         const { stderr } = await runInfo(['--npmg', '--npmPackages']);
    > 39 |         expect(stderr).toHaveLength(0);
         |                        ^
      40 |     });
      41 | });
      42 | 

      at Object.<anonymous> (test/info/info-multi-args.test.js:39:24)


Test Suites: 3 failed, 3 skipped, 39 passed, 42 of 45 total
Tests:       12 failed, 3 skipped, 101 passed, 116 total
Snapshots:   0 total
Time:        75.308s
Ran all test suites matching /test\//i.
Force exiting Jest: Have you considered using `--detectOpenHandles` to detect async operations that kept running after all tests finished?
�[2K�[1Gerror Command failed with exit code 1.
�[2K�[1Ginfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
�[2K�[1Gerror Command failed with exit code 1.
�[2K�[1Ginfo Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
The command "yarn test:ci" exited with 1.
store build cache [...]

Done. Your build exited with 1.

See complete report here.

knagaitsev · 2020-03-31T16:39:21Z

Seems to be a bad test run

wizardofhogwarts

Lgtm

alexander-akait · 2020-03-31T18:58:30Z

@Loonride ignore it, we migrate on github actions

knagaitsev requested a review from a team as a code owner March 27, 2020 03:57

webpack-bot added PR: unreviewed PR: CI-not-ok PR: CI-ok and removed PR: CI-not-ok labels Mar 27, 2020

jamesgeorge007 reviewed Mar 27, 2020

View reviewed changes

packages/generators/src/addon-generator.ts Outdated Show resolved Hide resolved

rishabh3112 previously approved these changes Mar 27, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: unreviewed labels Mar 27, 2020

snitin315 previously approved these changes Mar 27, 2020

View reviewed changes

himanshu010 previously approved these changes Mar 27, 2020

View reviewed changes

anshumanv reviewed Mar 27, 2020

View reviewed changes

packages/generators/src/addon-generator.ts Show resolved Hide resolved

packages/generators/src/init-generator.ts Show resolved Hide resolved

wizardofhogwarts previously approved these changes Mar 29, 2020

View reviewed changes

knagaitsev dismissed stale reviews from wizardofhogwarts, himanshu010, snitin315, and rishabh3112 via fc17a6f March 30, 2020 07:21

webpack-bot added the PR: unreviewed label Mar 30, 2020

alexander-akait previously approved these changes Mar 31, 2020

View reviewed changes

webpack-bot removed the PR: unreviewed label Mar 31, 2020

jamesgeorge007 dismissed alexander-akait’s stale review via 0ac4069 March 31, 2020 12:48

webpack-bot added PR: unreviewed PR: CI-not-ok and removed PR: CI-ok labels Mar 31, 2020

jamesgeorge007 force-pushed the fix/generator-issues-1 branch from 0ac4069 to 11d751c Compare March 31, 2020 12:57

webpack deleted a comment from webpack-bot Mar 31, 2020

jamesgeorge007 force-pushed the fix/generator-issues-1 branch 4 times, most recently from fb925b1 to 11d751c Compare March 31, 2020 13:32

jamesgeorge007 requested changes Mar 31, 2020

View reviewed changes

webpack-bot added PR: reviewed-changes-requested and removed PR: unreviewed labels Mar 31, 2020

knagaitsev added 9 commits March 31, 2020 10:51

fix(generators): fix small issues with generators

0531065

tests(generators): switch to only asserting that sw js exists

6f8ec32

tests(generator): removed sw js check test

775b6c8

tests(generators): add many init tests

12a4c1a

tests(generators): added addon generator tests for install scheduler

9dfc673

tests(generators): add addon generator tests for directory creation

790205d

chore(generators): remove unnecessary logging

2670ac8

chore(cli): move rimraf to global deps

7e2300e

chore(generators): remove yarn lock

ee45262

knagaitsev force-pushed the fix/generator-issues-1 branch from 11d751c to ee45262 Compare March 31, 2020 15:53

webpack-bot added PR: review-outdated and removed PR: reviewed-approved PR: reviewed-changes-requested labels Mar 31, 2020

Merge branch 'next' into fix/generator-issues-1

97fa1d6

Merge branch 'next' into fix/generator-issues-1

5c4b42b

wizardofhogwarts approved these changes Mar 31, 2020

View reviewed changes

webpack-bot added PR: reviewed-approved and removed PR: review-outdated labels Mar 31, 2020

alexander-akait merged commit f62c60d into webpack:next Apr 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(generators): fix small issues with generators #1385

fix(generators): fix small issues with generators #1385

knagaitsev commented Mar 27, 2020 •

edited

Loading

anshumanv left a comment

alexander-akait left a comment

jamesgeorge007 left a comment

webpack-bot commented Mar 31, 2020

webpack-bot commented Mar 31, 2020

knagaitsev commented Mar 31, 2020

wizardofhogwarts left a comment

alexander-akait commented Mar 31, 2020

fix(generators): fix small issues with generators #1385

fix(generators): fix small issues with generators #1385

Conversation

knagaitsev commented Mar 27, 2020 • edited Loading

anshumanv left a comment

Choose a reason for hiding this comment

alexander-akait left a comment

Choose a reason for hiding this comment

jamesgeorge007 left a comment

Choose a reason for hiding this comment

webpack-bot commented Mar 31, 2020

webpack-bot commented Mar 31, 2020

knagaitsev commented Mar 31, 2020

wizardofhogwarts left a comment

Choose a reason for hiding this comment

alexander-akait commented Mar 31, 2020

knagaitsev commented Mar 27, 2020 •

edited

Loading