Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refactor info package #1382

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
refactor/feature.

  • Display all info and remove unnecessary flags

Did you add tests for your changes?
WIP

If relevant, did you update the documentation?
WIP

Summary
Would be adding info package as direct dependency as per roadmap

Does this PR introduce a breaking change?
No

Other information
No

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need improve tests

test/info/info-help.test.js Show resolved Hide resolved
@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you provide example of current output? I think we should migrate on snapshots in future

@rishabh3112
Copy link
Member Author

Snapshots for testing is a bad idea IMO. On different testing environments (windows, linux, macOS, ...) output would be different on each one of them.

Here is output:
image

image

image

I use WSL and don't have any browser installed over there, so no browsers :)

@alexander-akait
Copy link
Member

alexander-akait commented Mar 31, 2020

Snapshots for testing is a bad idea IMO. On different testing environments (windows, linux, macOS, ...) output would be different on each one of them.

No, it is good idea, we should remove/mock platform specific output from snapshot (like do it webpack)

@rishabh3112
Copy link
Member Author

rishabh3112 commented Mar 31, 2020

@evilebottnawi System output is very important for info command, and it is system specific IMO. Or am I missing some information here?

@alexander-akait
Copy link
Member

Now I have to spar every time what the output looks like, it’s extremely inconvenient and I can skip some regressions, run it locally every time and look very time-consuming, so we need to simplify this

@alexander-akait
Copy link
Member

@rishabh3112 I will improve tests in future and you see how it is better, let's avoid it here, just provide example current default output

@rishabh3112
Copy link
Member Author

Here it is #1382 (comment)

@rishabh3112
Copy link
Member Author

@evilebottnawi also should I add the info as direct dependency in this PR itself, or should we release it info first to npm with current changes?

@alexander-akait
Copy link
Member

Let's rename npmPackages: to Packages: and globalNpmPackages to Global packages:

@evilebottnawi also should I add the info as direct dependency in this PR itself, or should we release it info first to npm with current changes?

In the next PR

@rishabh3112
Copy link
Member Author

rishabh3112 commented Mar 31, 2020

Replaced output:
image

@evilebottnawi anything else?

Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I think it should be merged. @evilebottnawi @rishabh3112 @anshumanv

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thanks!

@alexander-akait alexander-akait merged commit 7729d0b into webpack:next Apr 1, 2020
@alexander-akait
Copy link
Member

Thanks, feel free to integrate env package into CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants