-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests(utils): add packageUtils tests #1375
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those are some comprehensive tests, well done!
Thanks! |
What kind of change does this PR introduce?
tests/fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
N/A
Summary
I added tests for the
packageUtils
file.I also made some fixes and changes to the
getPackageManager
function. If ayarn.lock
is not present but apackage-lock.json
is present, I think we should assume the user wants to use npm.Does this PR introduce a breaking change?
Yes, as noted above in the
getPackageManager
functionOther information