-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(packages): make packages have correct main paths to index #1366
fix(packages): make packages have correct main paths to index #1366
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, one note
yarn.lock
Outdated
version "3.10.3" | ||
resolved "https://registry.yarnpkg.com/webpack-dev-server/-/webpack-dev-server-3.10.3.tgz#f35945036813e57ef582c2420ef7b470e14d3af0" | ||
integrity sha512-e4nWev8YzEVNdOMcNzNeCN947sWJNd43E5XvsJzbAL08kGc2frm1tQ32hTJslRS+H65LCb/AaUCYU7fjHCpDeQ== | ||
webpack-dev-server@3.8.0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here something wrong, we don't update lock file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reverted it back to original. It looks like the lock file was updated in a recent commit anyway, so there should be no problems either way.
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
What kind of change does this PR introduce?
fix
Did you add tests for your changes?
N/A
If relevant, did you update the documentation?
N/A
Summary
Some of the paths to main index scripts were incorrect, causing the modules to fail
Does this PR introduce a breaking change?
No
Other information
Edit: I went through all the packages to make sure everything was correct, but certainly double-check that I didn't miss anything.