-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add stats detailed option #1359
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Stats don't include detailed
officially, and I can't find it in webpack v5
too. Sharing a supporting reference for it would be great.
For reference: https://webpack.js.org/configuration/stats/#stats
@rishabh3112 here - https://github.com/webpack/webpack/blob/f0b1a71d5a4ba7a685e76d08281195364d7dd9b3/lib/stats/DefaultStatsPresetPlugin.js#L47 Probably it needs to be documented too, I'll open an issue in the docs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good one note
Thanks for insight @anshumanv. It is good now :) |
@anshumanv Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
@evilebottnawi @rishabh3112, should be good now. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @webpack/cli-team need more reviews
What kind of change does this PR introduce?
added stats detailed option which was unrecognized.
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
Does this PR introduce a breaking change?
No
Other information
NA