fix(webpack-cli): prefer import-local

[snitin315]

What kind of change does this PR introduce?

removed stale import-local

Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Fixes #1318

Does this PR introduce a breaking change?

NO

Other information

[alexander-akait]

Remove from dependencies too

[webpack-bot]

@snitin315 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@evilebottnawi Please review the new changes.

[alexander-akait]

Update lock file too

[snitin315]

Update lock file too

lock file is not present, all lock files are being ignored except the root lock file

[alexander-akait]

And we still should update lock file, when something changes in dependencies/devDependencies in package.json you always need regenerate lock file

[snitin315]

And we still should update lock file, when something changes in dependencies/devDependencies in package.json you always need regenerate lock file

I did generate again, but no changes to stage and commit.

[alexander-akait]

Oh, sorry I was wrong, we should not remove import-local, we should uncomment return;.

How it is package works - if we have globally installed webpack-cli, it is require local installed webpack-cli package (from local node_modules) and continue execution (https://github.com/sindresorhus/import-local/blob/master/index.js#L18), if it is locally we just continue execution

[snitin315]

unable to commit changes, getting the following error -

Tried disabling eslint for the line, doesn't work as well
Do I have to make changes in eslint conf?

[alexander-akait]

Do I have to make changes in eslint conf?

Yes, only for that file, use overrides https://eslint.org/docs/user-guide/configuring and setup right parserOptions (ecmaFeatures.globalReturn: true)

[webpack-bot]

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

[snitin315]

overrides were throwing warning as well,

    overrides: [
        {
            files: ['./bin/cli.js'],
            parserOptions: {
                ecmaFeatures: {
                    globalReturn: true,
                },
            },
        },
    ],

So, I wrapped the logic inside IIFE. please check if it's ok to do so.

[alexander-akait]

overrides were throwing warning as well,

Eslint have cli args to check what rules used for file, okay, I will fix it soon

So, I wrapped the logic inside IIFE. please check if it's ok to do so.

No, it is wrong

[alexander-akait]

Please remove IIFE and wait merge #1348

[alexander-akait]

Tested locally and all fine, we will need to add tests in the future (when we starts increase coverage)