-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-cli): prefer import-local #1345
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove from dependencies too
4868ebf
to
d41b606
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evilebottnawi Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update lock file too
lock file is not present, all lock files are being ignored except the root lock file |
And we still should update lock file, when something changes in dependencies/devDependencies in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, sorry I was wrong, we should not remove import-local
, we should uncomment return;
.
How it is package works - if we have globally installed webpack-cli
, it is require local
installed webpack-cli
package (from local node_modules
) and continue execution (https://github.com/sindresorhus/import-local/blob/master/index.js#L18), if it is locally we just continue execution
Yes, only for that file, use |
d41b606
to
6eecb26
Compare
637f38f
to
f0d30ef
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
f0d30ef
to
1863015
Compare
Eslint have cli args to check what rules used for file, okay, I will fix it soon
No, it is wrong |
Please remove IIFE and wait merge #1348 |
1863015
to
a4475cb
Compare
Tested locally and all fine, we will need to add tests in the future (when we starts increase coverage) |
What kind of change does this PR introduce?
removed stale import-local
Did you add tests for your changes?
NA
If relevant, did you update the documentation?
NA
Summary
Fixes #1318
Does this PR introduce a breaking change?
NO
Other information