fix: add configuration for mode option none #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
|
This is confusing. Why don't you add the fix inside the PR where you created the test? |
Actually I checked out a new branch before jumping into the issue. I realized it later after fixing the bug, Sorry for the confusion I created. It won't happen again in the future.
|
|
It's not a problem, but it's so confusing that I don't know what I have to do 😅 could you please help? |
|
You can merge this pull request then I will rebase the test PR, and that will fix everything. |
ematipico
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Fixes #1302
Did you add tests for your changes?
corresponding test -> #1301
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
NO
Other information