-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): stats #1299
Merged
Merged
feat(webpack-cli): stats #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1ab8eee
to
e7e99c3
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
jamesgeorge007
requested changes
Mar 7, 2020
usage: 'webpack --verbose', | ||
type: Boolean, | ||
group: DISPLAY_GROUP, | ||
description: 'It tells to webpack to output all the information', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
description: 'It tells to webpack to output all the information', | |
description: 'It tells webpack to output all the information', |
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
Amended also the usage of output. `--standard` has been removed and `--pretty` will show the fancy output, which is experimental.
fc2e179
to
4d7208a
Compare
jamesgeorge007
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
It implements the
stats
option for webpack via CLI.Closes #1298
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
These options https://webpack.js.org/configuration/stats/#stats are now passed to the compiler via CLI.
I also removed the "fancy" output with the table. I had a discussion with the core maintainers about the library. The CLI should not alter the output of the compiler. I left
--pretty
as option, so we can still use but it is experimental.Does this PR introduce a breaking change?
Kind of because it removed
--standard
flag.Other information