-
-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): add no-hot flag #1296
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work I think. We should cover more cases with tests
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please create the following tests:
- with a configuration file where there's
devServer: { hot: true }
- a test for the serve command (webpack-dev-server consumes the flag)
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should suspend this work until we merge #1347
What kind of change does this PR introduce?
Added
--no-hot
flag to CLI.Did you add tests for your changes?
YES
If relevant, did you update the documentation?
YES
Summary
Refers #1240
Refers #1012
Does this PR introduce a breaking change?
NO
Other information