-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webpack-cli): handle promise rejection with package installation #1284
fix(webpack-cli): handle promise rejection with package installation #1284
Conversation
adeba96
to
ba059b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create a test?
@ematipico it requires to mock the keyboard interrupts, and is gonna consume some sort of third party libraries for the purpose. |
With jest you can mock libraries or modules. I believe it's doable |
ffe7a6b
to
a164a67
Compare
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
37f7873
to
dd914e0
Compare
90fc912
to
fb1adbe
Compare
fb1adbe
to
d7f11a0
Compare
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
d7f11a0
to
8d479a8
Compare
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
closes #1283
Does this PR introduce a breaking change?
Nope
Other information
N/A