-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack-cli): add no-mode flag #1276
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test, update the documentation and the snapshot tests
68bd64a
to
372e5f0
Compare
372e5f0
to
a916dd1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the way --no-mode
is retrieved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some other refactor can be done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for putting efforts!
Try to open PRs as draft pull requests in case you feel they are work in progress in future 😉.
@ematipico @rishabh3112 , Yes there is a bug It should accept only Shoul I open a seperate issue for this? can you please verify? |
Argument validation will be part of another story. Don't worry about it. |
da88754
to
d952ca1
Compare
d952ca1
to
3497e84
Compare
3497e84
to
d1424f8
Compare
81418fc
to
629b16f
Compare
Could you rebase your branch please? |
@ematipico already done 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also have to update the snapshot tests
629b16f
to
6a45b54
Compare
@snitin315 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
@ematipico can you help me fix the CI , dont know why scss test is failing. |
Please add a |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
What kind of change does this PR introduce?
feature - add
no-mode
flagDid you add tests for your changes?
Work in progress.
If relevant, did you update the documentation?
Yes
Summary
Refers #1240
Refers #1012
Does this PR introduce a breaking change?
Other information