-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: handle promise rejection happening with cli-executor #1269
fix: handle promise rejection happening with cli-executor #1269
Conversation
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can have a more friendly error message
@ematipico got any suggestions? |
I don't at the moment. But you can come up with a better wording :) |
Co-Authored-By: Anshuman Verma <anshu.av97@gmail.com>
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
closes #1268
Does this PR introduce a breaking change?
Nope
Other information
N/A