fix: handle promise rejection happening with cli-executor #1269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Feb 26, 2020
@ematipico got any suggestions? |
|
I don't at the moment. But you can come up with a better wording :) |
anshumanv
reviewed
Feb 26, 2020
Co-Authored-By: Anshuman Verma <anshu.av97@gmail.com>
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-approved
PR: reviewed-changes-requested
labels
|
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
snitin315
reviewed
Feb 27, 2020
ematipico
approved these changes
Feb 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
bugfix
Did you add tests for your changes?
Nope
If relevant, did you update the documentation?
N/A
Summary
closes #1268
Does this PR introduce a breaking change?
Nope
Other information
N/A