-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create a cli executer #1255
Conversation
Interesting! What are we planning though? Throw this prompt when an invalid flag is supplied? |
@anshumanv |
Sounds fair, though I think adding it just as a separate flag would be better since we for now show help on detecting any invalid flag, so user can correct any typos they made, it would be slower to show a prompt and ask them to enter the flags over again rather than correct just some invalid flag. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
Sure it may slows down but as a CLI our first focus should be on user's successful interaction with the CLI i.e. helping user getting their work done instead of keep on correcting them. |
Ah didn't see the flag picker screenshot before, that can help surely, let's see how this turns out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review the approach of the algorithm. There's too much going on that doesn't help understanding what the code is doing. Also, if you believe you're doing something hacky or strange, please comment the code
Thanks for the detailed review :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use this :)
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/for-await...of
Way better!
Thanks! updated the code now. |
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @jamesgeorge007 Please review the new changes. |
Added descriptions as per suggestion by @ematipico |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work 👏
* feat: create cli executer * chore: remove unused variables * fix: code style * chore: use for await * chore: add descriptions for options
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
![image](https://user-images.githubusercontent.com/15812317/75105073-c31e7f80-5636-11ea-84e4-af0116e6e72f.png)
I am creating a CLI executer that will be used in case of invalid/unknown args.
Currently it looks like this
After this is merged, I would add this in appropriate places
Does this PR introduce a breaking change?
No
Other information
Improving intractability with cli