feat(webpack-cli): added mode argument #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ematipico
force-pushed
the
feature/mode-arguments
branch
from
97ae08e
to
659a243
Compare
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
anshumanv
requested changes
Feb 22, 2020
test/mode/prod/prod.test.js
Outdated
| const { stat } = require('fs'); | ||
| const { resolve } = require('path'); | ||
| describe('mode flags', () => { | ||
| it('should load a development config when --prod is passed', done => { |
There was a problem hiding this comment.
Suggested change
| it('should load a development config when --prod is passed', done => { | |
| it('should load a production config when --prod is passed', done => { |
test/mode/prod/prod.test.js
Outdated
| }); | ||
|
|
||
| it('should load a development config when --mode=production is passed', done => { | ||
| const { stderr, stdout } = run(__dirname, ['--prod', 'production']); |
There was a problem hiding this comment.
Did you mean?
Suggested change
| const { stderr, stdout } = run(__dirname, ['--prod', 'production']); | |
| const { stderr, stdout } = run(__dirname, ['--mode', 'production']); |
| expect(stats.isFile()).toBe(true); | ||
| done(); | ||
| }); | ||
| }); |
There was a problem hiding this comment.
You can add another case of using both --prod and --dev which should use prod config.
ematipico
force-pushed
the
feature/mode-arguments
branch
from
659a243
to
252f50e
Compare
|
@ematipico Thanks for your update. I labeled the Pull Request so reviewers will review it again. @anshumanv Please review the new changes. |
webpack-bot
added
PR: review-outdated
and removed
PR: reviewed-changes-requested
labels
|
@anshumanv thank you for your inputs! PR updated :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature, it adds back
modeargumentDid you add tests for your changes?
Yes
If relevant, did you update the documentation?
Yes
Summary
People asked to have back the
modeargument.Does this PR introduce a breaking change?
No
Other information