-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing the typos and grammatical errors in Readme files #1246
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your commit is not as expected, please commit using npm run commit
or yarn commit
I uses Sent from my VIBE K6 Power using FastHub |
We have specific commit guidelines which are most easily to adhere to using the commit helper package that we use, just do |
packages/webpack-scaffold/README.md
Outdated
@@ -86,7 +86,7 @@ this.configuration.myScaffold.webpackOptions.entry = createDynamicPromise(["app. | |||
|
|||
Param: `String` | |||
|
|||
Used to create an [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter) | |||
Used to create a [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The former was fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for correcting @jamesgeorge007
@@ -86,7 +86,7 @@ this.configuration.myScaffold.webpackOptions.entry = createDynamicPromise(["app. | |||
|
|||
Param: `String` | |||
|
|||
Used to create an [assetFilterFunction](https://webpack.js.org/configuration/performance/#performance-assetfilter) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think an
is correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above conversation, self-explanatory
Also please sign the CLA. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to be that the change made is not what is pointed to in the screenshot shared. @mohitm15 You should revert the change you made and make the change where you shown in the screenshot. That's correct. @rishabh3112 is requested to review.
Getting error logs while running it |
What errors? Trace? |
@mohitm15 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @wizardofhogwarts Please review the new changes. |
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Did you install the project dependencies? |
Maybe you wanted to do |
NO , can you direct me to the link of project setup on local machine |
Thanks @mohitm15 |
@anshumanv I am facing a problem regarding comminting the changes for my next PR. Can we have chat over gitter channel |
Sure we can, what's the problem exactly? Doing a discussion here will also help anyone who is having similar issues so I'd recommend doing it here. |
Sure I had made changes in a separate branch for my latest issue, but after adding the changes using |
What's the error? Are you sure you did yarn install? |
Yes |
refer #1267 . Make sure your branch is up-to-date with upstream and have this commit . |
What kind of change does this PR introduce?
Bug Fix, fixes the issue #1245
If relevant, did you update the documentation?
Yes, Security.md and webpack-scaffold/readme.md
Summary
Fixing the typos and grammatical errors in Readme files
Does this PR introduce a breaking change?
No
Other information