Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add progress bar for progress flag #1238

Merged
merged 4 commits into from
Feb 18, 2020

Conversation

rishabh3112
Copy link
Member

@rishabh3112 rishabh3112 commented Feb 18, 2020

What kind of change does this PR introduce?
feature

Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Add a real progress bar for--progress flag.
image

Does this PR introduce a breaking change?
Yes

Other information

@rishabh3112 rishabh3112 changed the title feat: add progress bar in progress feat: add progress bar for progress flag Feb 18, 2020
Copy link
Contributor

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one comment

packages/webpack-cli/lib/utils/Compiler.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@rishabh3112 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@ematipico Please review the new changes.

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor stuff

packages/webpack-cli/lib/utils/Compiler.js Show resolved Hide resolved
process.stdout.cursorTo(0);
if (percent !== undefined) {
process.stdout.write(' (')
for(let i = 0; i <= 100; i+=10) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for(let i = 0; i <= 100; i+=10) {
for (let i = 0; i <= 100; i+=10) {

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is prettier not running for this file?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup I think so, let me check.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably you did a commit and skipped the git hooks?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had to run eslint with --no-ignore for it to lint.

@ematipico ematipico merged commit 06129a1 into webpack:next Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants