-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add progress bar for progress flag #1238
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one comment
@rishabh3112 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @ematipico Please review the new changes. |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor stuff
process.stdout.cursorTo(0); | ||
if (percent !== undefined) { | ||
process.stdout.write(' (') | ||
for(let i = 0; i <= 100; i+=10) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for(let i = 0; i <= 100; i+=10) { | |
for (let i = 0; i <= 100; i+=10) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is prettier not running for this file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yup I think so, let me check.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably you did a commit and skipped the git hooks?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to run eslint with --no-ignore
for it to lint.
What kind of change does this PR introduce?
feature
Did you add tests for your changes?
No
If relevant, did you update the documentation?
No
Summary
![image](https://user-images.githubusercontent.com/15812317/74743916-45015800-5287-11ea-9c55-f683855c65a1.png)
Add a real progress bar for
--progress
flag.Does this PR introduce a breaking change?
Yes
Other information