fix(init): fix webpack config scaffold in init package #1231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix webpack config scaffold ISSUES CLOSED: webpack#1230
anshumanv
commented
Feb 16, 2020
| @@ -130,8 +144,8 @@ export default function modifyHelperUtil(action: string, generator: typeof Gener | |||
|
|
|||
| const successMessage = `\nYou can now run ${chalk.green(runCommand)} to bundle your application!\n\n`; | |||
| process.stdout.write(`\n${successMessage}`); | |||
| return; | |||
There was a problem hiding this comment.
We were exiting before actually creating the config.
|
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
ematipico
suggested changes
Feb 17, 2020
|
Lock files seem out of sync and need to be updated eventually, should I do that in a separate PR @ematipico ? |
|
That's strange because I don't get all these changes locally. Though, it would be better to do it on a separate PR |
|
Sounds good! Will push another commit.
Can you try running npm run bootstrap? I got these when I did that I believe. |
|
OK no problem, we will soon switch to |
ematipico
approved these changes
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix webpack config scaffold
ISSUES CLOSED: #1230
What kind of change does this PR introduce?
bugfix, sync lock files
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Function to generate webpack config file was being skipped, fixed it.
Does this PR introduce a breaking change?
Fixes instead.
Other information