-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(init): fix webpack config scaffold in init package #1231
Conversation
fix webpack config scaffold ISSUES CLOSED: webpack#1230
@@ -130,8 +144,8 @@ export default function modifyHelperUtil(action: string, generator: typeof Gener | |||
|
|||
const successMessage = `\nYou can now run ${chalk.green(runCommand)} to bundle your application!\n\n`; | |||
process.stdout.write(`\n${successMessage}`); | |||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We were exiting before actually creating the config.
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good but could you remove from the PR the lock files? That's strange there are so many changes
Lock files seem out of sync and need to be updated eventually, should I do that in a separate PR @ematipico ? |
That's strange because I don't get all these changes locally. Though, it would be better to do it on a separate PR |
Sounds good! Will push another commit.
Can you try running npm run bootstrap? I got these when I did that I believe. |
OK no problem, we will soon switch to |
fix webpack config scaffold
ISSUES CLOSED: #1230
What kind of change does this PR introduce?
bugfix, sync lock files
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
NA
Summary
Function to generate webpack config file was being skipped, fixed it.
Does this PR introduce a breaking change?
Fixes instead.
Other information