Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: test case for passing in unknown flags #1214

Merged
merged 1 commit into from
Feb 12, 2020

Conversation

jamesgeorge007
Copy link
Member

What kind of change does this PR introduce?
test update

Did you add tests for your changes?
Yep

If relevant, did you update the documentation?
Nope

Summary
Added test case for passing in unknown flags.

Does this PR introduce a breaking change?
Nope

Other information
N/A

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

Copy link
Contributor

@wizardofhogwarts wizardofhogwarts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@rishabh3112 rishabh3112 merged commit e0c359e into webpack:next Feb 12, 2020
@rishabh3112
Copy link
Member

Thanks!

@jamesgeorge007 jamesgeorge007 deleted the feat/default-test-case branch February 12, 2020 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants