-
-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: show warning if bail and watch are used together #1804
Conversation
29a3b95
to
a3e8ee8
Compare
ffd35ce
to
6021ee3
Compare
1f54e89
to
52b7029
Compare
expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
}); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add tests where bail: false
and watch: true
/watch: false
and bail: true
and check there is not warnings/errors?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added
52b7029
to
c43b93b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a small suggestion.
Rest looks good to me.
@@ -0,0 +1,7 @@ | |||
const logger = require('../logger'); | |||
|
|||
module.exports = (compiler) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assign this to variable and then assign it to module.exports
.
Add a comment about function(or file) as well.
685df00
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @evenstensberg Please review the new changes. |
What kind of change does this PR introduce?
maybe fix
Did you add tests for your changes?
Yes
If relevant, did you update the documentation?
No
Summary
Fixes #1794
show a warning if
bail
andwatch
are used together with either config or as cli args.Does this PR introduce a breaking change?
No
Other information
No