-
-
Notifications
You must be signed in to change notification settings - Fork 597
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: show warning if bail and watch are used together (#1804)
* fix: show warning if bail and watch are used together * fix: watch * tests: update * chore: add comments Co-authored-by: James George <jamesgeorge998001@gmail.com>
- Loading branch information
1 parent
4014808
commit 6140b24
Showing
9 changed files
with
79 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 14 additions & 0 deletions
14
packages/webpack-cli/lib/utils/warnings/bailAndWatchWarning.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,14 @@ | ||
const logger = require('../logger'); | ||
|
||
/** | ||
* warn the user if bail and watch both are used together | ||
* @param {Object} webpack compiler | ||
* @returns {void} | ||
*/ | ||
const bailAndWatchWarning = (compiler) => { | ||
if (compiler.options.bail && compiler.options.watch) { | ||
logger.warn('You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.'); | ||
} | ||
}; | ||
|
||
module.exports = bailAndWatchWarning; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,26 @@ | ||
'use strict'; | ||
|
||
const { run } = require('../utils/test-utils'); | ||
|
||
describe('bail and watch warning', () => { | ||
it('should log warning in case of single compiler', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'single-webpack.config.js']); | ||
|
||
expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
|
||
it('should log warning in case of multiple compilers', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'multi-webpack.config.js']); | ||
|
||
expect(stderr).toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
|
||
it('should log not log warning if both are not true', () => { | ||
const { stderr, stdout } = run(__dirname, ['-c', 'third-webpack.config.js']); | ||
|
||
expect(stderr).not.toContain(`You are using "bail" with "watch". "bail" will still exit webpack when the first error is found.`); | ||
expect(stdout).toBeTruthy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
module.exports = [ | ||
{ | ||
output: { | ||
filename: './dist-first.js', | ||
}, | ||
name: 'first', | ||
entry: './src/first.js', | ||
mode: 'development', | ||
}, | ||
{ | ||
output: { | ||
filename: './dist-second.js', | ||
}, | ||
name: 'second', | ||
entry: './src/second.js', | ||
mode: 'production', | ||
bail: true, | ||
watch: true, | ||
}, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
module.exports = { | ||
entry: './src/first.js', | ||
mode: 'development', | ||
bail: true, | ||
watch: true, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('bail and watch warning test first'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('bail and watch warning test second'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
module.exports = { | ||
entry: './src/first.js', | ||
mode: 'development', | ||
bail: true, | ||
}; |