-
-
Notifications
You must be signed in to change notification settings - Fork 597
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
* fix: mode behaviour * fix: mode behaviour
- Loading branch information
Showing
7 changed files
with
164 additions
and
30 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,49 @@ | ||
const PRODUCTION = 'production'; | ||
const DEVELOPMENT = 'development'; | ||
|
||
const resolveMode = (args) => { | ||
/* | ||
Mode priority: | ||
- Mode flag | ||
- Mode from config | ||
- Mode form NODE_ENV | ||
*/ | ||
|
||
/** | ||
* | ||
* @param {string} mode - mode flag value | ||
* @param {Object} configObject - contains relevant loaded config | ||
*/ | ||
const assignMode = (mode, configObject) => { | ||
const { | ||
env: { NODE_ENV }, | ||
} = process; | ||
const { mode } = args; | ||
|
||
const { mode: configMode } = configObject; | ||
let finalMode; | ||
/** | ||
* It determines the mode to pass to webpack compiler | ||
* @returns {string} The mode | ||
*/ | ||
if (!mode && NODE_ENV && (NODE_ENV === PRODUCTION || NODE_ENV === DEVELOPMENT)) { | ||
if (mode) { | ||
finalMode = mode; | ||
} else if (configMode) { | ||
finalMode = configMode; | ||
} else if (NODE_ENV && (NODE_ENV === PRODUCTION || NODE_ENV === DEVELOPMENT)) { | ||
finalMode = NODE_ENV; | ||
} else { | ||
finalMode = mode || PRODUCTION; | ||
finalMode = PRODUCTION; | ||
} | ||
return { mode: finalMode }; | ||
}; | ||
|
||
/** | ||
* | ||
* @param {Object} args - parsedArgs from the CLI | ||
* @param {Object | Array} configOptions - Contains loaded config or array of configs | ||
*/ | ||
const resolveMode = (args, configOptions) => { | ||
const { mode } = args; | ||
let resolvedMode; | ||
if (Array.isArray(configOptions)) { | ||
resolvedMode = configOptions.map((configObject) => assignMode(mode, configObject)); | ||
} else resolvedMode = assignMode(mode, configOptions); | ||
|
||
return { | ||
options: { mode: finalMode }, | ||
}; | ||
return { options: resolvedMode }; | ||
}; | ||
|
||
module.exports = resolveMode; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
// eslint-disable-next-line node/no-unpublished-require | ||
const WebpackCLITestPlugin = require('../../utils/webpack-cli-test-plugin'); | ||
|
||
module.exports = { | ||
plugins: [new WebpackCLITestPlugin()], | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters