fix(index): relax default asset name {RegExp} (options.test)

[alexander-akait]

Issues

• Fixes uglifyjs-webpack-plugin cannot uglify any file #220

[michael-ciniawsky]

The . needs to be escaped (?)

- /.js
+ /\.js...

Why ((js)?) ('nested' capturing groups) ?

[alexander-akait]

@michael-ciniawsky done 👍

[michael-ciniawsky]

👍

[michael-ciniawsky]

Released in v1.2.3 🎉

[jazdw]

@evilebottnawi was it intentional to match the .j extension? Also an empty query should probably be allowed. Maybe \.js(\?.*)?$?

[michael-ciniawsky]

was it intentional to match the .j extension?

The common default at this stage of the build is a JS asset ending in .js (output.filename/output.chunkFilename), it's possible to override this via options.test in case it's needed (but optional)

Also an empty query should probably be allowed. Maybe .js(?.*)?$?

What's the 'use case' for an empty query? Why/When would someone do this ? But the {RegExp} could eventually be further relaxed/changed if there is a case made :)

[jazdw]

I'm not following you, maybe I didn't make myself clear. The Regex in the commit will match files with a .js and a .j extension which I don't think is desirable or the intention.

There's not a use case per say, just in case someone uses a variable substitution that evaluates to an empty string.

[jazdw]

@evilebottnawi @michael-ciniawsky any comment on the Regex?

edit. This demonstrates the incorrect behaviour - https://regex101.com/r/SJm7SO/1

[alexander-akait]

@jazdw oh, yes, you are right we should fix it 👍