This repository has been archived by the owner on Sep 28, 2020. It is now read-only.
support eslint@4.x #178
Merged
support eslint@4.x #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where did you find errors? Is it related to latest version? Latest build was ok https://travis-ci.org/MoOx/eslint-loader/builds/217043093 |
|
update the OP. |
|
ci failed on node@v4.
why this error? 4.0.0-rc.0 < 5.0.0. right? |
|
@MoOx eslint@4.0.0 released. it seems all the tests passed. you can merge the PR. :) |
4 tasks
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request? (put an "X" next to item)
[x] Other, please explain: support eslint@v4 (fixes #177 )
What changes did you make? (Give an overview)
Is there anything you'd like reviewers to focus on?
max-lenerrors, change the config 80 to 120.