Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatiblity of methods with native return type in PHP 8.1 #1011

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

SilinMykola
Copy link
Contributor

This pull request (PR) provides fixes for the extension to make it compatible with PHP 8.1.
The fixes provides backward compatibility with previous versions PHP.

Return types have been fixed using attribute #[\ReturnTypeWillChange], please see this link

@spawnia spawnia added the bug label Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #1011 (efe46aa) into master (2bac02f) will decrease coverage by 0.01%.
The diff coverage is 33.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1011      +/-   ##
============================================
- Coverage     94.49%   94.47%   -0.02%     
- Complexity       50       53       +3     
============================================
  Files           120      120              
  Lines          9634     9637       +3     
============================================
+ Hits           9104     9105       +1     
- Misses          530      532       +2     
Impacted Files Coverage Δ
src/Error/Error.php 94.00% <0.00%> (-0.95%) ⬇️
src/Language/SourceLocation.php 75.00% <0.00%> (-6.82%) ⬇️
src/Type/Definition/Type.php 97.89% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2bac02f...efe46aa. Read the comment docs.

@spawnia spawnia changed the title Added fixes for extension for compatibility with PHP 8.1 Fix compatiblity of methods with native return type in PHP 8.1 Nov 15, 2021
@spawnia spawnia merged commit 51ad17c into webonyx:master Nov 15, 2021
spawnia pushed a commit that referenced this pull request Nov 15, 2021
@spawnia
Copy link
Collaborator

spawnia commented Nov 15, 2021

Thanks, fixed and backported to v14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants