Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw fund method #133

Merged
merged 3 commits into from
Oct 15, 2024
Merged

Withdraw fund method #133

merged 3 commits into from
Oct 15, 2024

Conversation

EmmanuelAR
Copy link
Collaborator

Pull Request

Changes description

Changes:

  1. Withdraw fund method
  2. Refactor setIsActive to setState
  3. Run scarb fmt
  4. Add new withdraw fund state

Comments

Needs to test in sepolia

@EmmanuelAR
Changes:
911cdbf 
1. Withdraw fund method
2. Refactor setIsActive to setState
3. Run scarb fmt
4. Add new withdraw fund state
@EmmanuelAR
Changes:
78cc4e0 
- fund ids start in 1
- withdraw method with contract balance, and working
-fixing tests
@adrianvrj adrianvrj marked this pull request as ready for review October 15, 2024 04:07
adrianvrj
adrianvrj requested changes Oct 15, 2024
View reviewed changes
contracts/src/fund.cairo Show resolved Hide resolved
@adrianvrj adrianvrj merged commit ffc002b into web3wagers:dev Oct 15, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianvrj adrianvrj adrianvrj approved these changes

@bitfalt bitfalt Awaiting requested review from bitfalt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Implement withdraw function on fund contract
2 participants
@EmmanuelAR @adrianvrj