Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(typos): fix typos #795

Merged
merged 18 commits into from
Mar 10, 2023
Merged

chore(typos): fix typos #795

merged 18 commits into from
Mar 10, 2023

Conversation

stavares843
Copy link
Contributor

Summary of Changes

Fixes #794

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

JeneaVranceanu
JeneaVranceanu requested changes Mar 9, 2023
View reviewed changes
Sources/Web3Core/Structure/SECP256k1.swift Outdated Show resolved Hide resolved
Sources/Web3Core/Structure/SECP256k1.swift Outdated Show resolved Hide resolved
@JeneaVranceanu
Copy link
Collaborator

@stavares843 Thanks for the update. All looks good, just a few quick variable renamings are required.

@stavares843
address review
d1623b8 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
27b76f7 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
ef0a008 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
5b0dba3 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
faba3e1 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
8954763 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
81357c5 
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
224c2ea 
Signed-off-by: Sara Tavares <29093946+stavares843@users.noreply.github.com>
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
@stavares843
address review
58fcb13 
Signed-off-by: Sara Tavares <29093946+stavares843@users.noreply.github.com>
Signed-off-by: Sara Tavares <saratavares843@gmail.com>
JeneaVranceanu
JeneaVranceanu previously approved these changes Mar 10, 2023
View reviewed changes
Copy link
Collaborator

@JeneaVranceanu JeneaVranceanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @stavares843!

@JeneaVranceanu JeneaVranceanu merged commit fd931fa into web3swift-team:develop Mar 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@JeneaVranceanu JeneaVranceanu JeneaVranceanu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix typos across codebase
3 participants
@stavares843 @JeneaVranceanu @janndriessen