Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: swiftlint auto fixes #761

Merged
merged 3 commits into from
Feb 9, 2023
Merged

chore: swiftlint auto fixes #761

merged 3 commits into from
Feb 9, 2023

Conversation

JeneaVranceanu
Copy link
Collaborator

Summary of Changes

Review only after #760 is merged

Result of swiftlint --fix. Should reduce the load on #756 and #759

Test Data or Screenshots

By submitting this pull request, you are confirming the following:
  • I have reviewed the Contribution Guidelines.
  • I have performed a self-review of my own code.
  • I have updated my repository to match the develop branch.
  • I have included test data or screenshots that prove my fix is effective or that my feature works.
  • I have checked that all tests work and swiftlint is not throwing any errors/warnings.

@JeneaVranceanu JeneaVranceanu added ready for review issue is resolved, a final review is needed before closing refactoring labels Feb 5, 2023
@JeneaVranceanu JeneaVranceanu self-assigned this Feb 5, 2023
@JeneaVranceanu JeneaVranceanu mentioned this pull request Feb 5, 2023
Merged
cclauss
cclauss previously approved these changes Feb 5, 2023
View reviewed changes
Copy link
Contributor

@cclauss cclauss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Easy to review even though there are lots of files modified.

janndriessen
janndriessen previously approved these changes Feb 6, 2023
View reviewed changes
@JeneaVranceanu JeneaVranceanu merged commit 3081a92 into web3swift-team:develop Feb 9, 2023
@cclauss
Copy link
Contributor

cclauss commented Feb 9, 2023

Nice work in this epic! Having this automation should save a ton of time and make the codebase consistent.

@JeneaVranceanu JeneaVranceanu deleted the chore/swiftlint-auto-fixes branch February 9, 2023 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janndriessen janndriessen janndriessen approved these changes

@cclauss cclauss cclauss approved these changes

@yaroslavyaroslav yaroslavyaroslav yaroslavyaroslav approved these changes

Assignees

@JeneaVranceanu JeneaVranceanu

Labels
ready for review issue is resolved, a final review is needed before closing refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JeneaVranceanu @cclauss @janndriessen @yaroslavyaroslav