Adding support for new API quorumExtension_generateExtensionApprovalU… #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…uid introduced in Quorum.
krishnan-narayanan-partior
requested review from
conor10 and
iikirilov
as code owners
…uid introduced in Quorum.
…uid introduced in Quorum.
|
@gtebrean @conor10 @iikirilov can I please request you to have a look at this PR? |
NickSneo
requested changes
Apr 21, 2023
src/integration-test/java/org/web3j/quorum/ExtensionRequestTest.java
Outdated
Show resolved
Hide resolved
src/integration-test/java/org/web3j/quorum/ExtensionResponseTest.java
Outdated
Show resolved
Hide resolved
|
agree with @NickSneo, in rest is g2g 👍 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow contract extension approval using an externally owned account a new API was introduced. Please refer to this PR request that was recently merged PR
What does this PR do?
This PR introduces support to call the new API method "quorumExtension_generateExtensionApprovalUuid"
All the required intergrations tests are in place and I have also fixed the broken integration tests on PermissionRequestTest.java
Where should the reviewer start?
Refer to the function "quorumExtensionGetApprovalUuid" in src/main/java/org/web3j/quorum/JsonRpc2_0Quorum.java
Also refer to the original PR in GoQuorum PR
Why is it needed?
To support invocation of the new API