-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ok/6984 update e2e network tests #7276
base: 4.x
Are you sure you want to change the base?
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 62345f7 | Previous: 6f9a485 | Ratio |
---|---|---|---|
processingTx |
21781 ops/sec (±7.84% ) |
21688 ops/sec (±8.58% ) |
1.00 |
processingContractDeploy |
39209 ops/sec (±6.72% ) |
38621 ops/sec (±6.70% ) |
0.99 |
processingContractMethodSend |
16480 ops/sec (±6.71% ) |
15698 ops/sec (±6.99% ) |
0.95 |
processingContractMethodCall |
28395 ops/sec (±6.59% ) |
28405 ops/sec (±6.07% ) |
1.00 |
abiEncode |
42674 ops/sec (±9.00% ) |
42626 ops/sec (±7.39% ) |
1.00 |
abiDecode |
31827 ops/sec (±6.65% ) |
29174 ops/sec (±8.52% ) |
0.92 |
sign |
1513 ops/sec (±3.83% ) |
1502 ops/sec (±3.88% ) |
0.99 |
verify |
367 ops/sec (±0.89% ) |
364 ops/sec (±0.56% ) |
0.99 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7276 +/- ##
=======================================
Coverage 94.43% 94.43%
=======================================
Files 216 216
Lines 8463 8463
Branches 2338 2338
=======================================
Hits 7992 7992
Misses 471 471
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #6984
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.