Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/4.13.0 #7264

Merged
merged 3 commits into from
Sep 18, 2024
Merged

release/4.13.0 #7264

merged 3 commits into from
Sep 18, 2024

Conversation

luu-alex
Copy link
Contributor

@luu-alex luu-alex commented Sep 17, 2024

Description

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

[4.13.0]

Added

web3-core

web3-eth

  • Adds the same {transactionSchema?: ValidationSchemaInput} that exists in formatTransaction to validateTransactionForSigning

Changed

web3-eth

  • Forwards the new web3Context.config.customTransactionSchema to formatTransaction

web3-eth-personal

  • Forwards the new web3Context.config.customTransactionSchema to formatTransaction

web3

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 640.67 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 621.26 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.38 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.28 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0799331 Previous: a21078b Ratio
processingTx 20780 ops/sec (±7.97%) 22494 ops/sec (±8.39%) 1.08
processingContractDeploy 37308 ops/sec (±6.11%) 38470 ops/sec (±7.11%) 1.03
processingContractMethodSend 14959 ops/sec (±9.07%) 16121 ops/sec (±6.53%) 1.08
processingContractMethodCall 27273 ops/sec (±6.34%) 28342 ops/sec (±6.29%) 1.04
abiEncode 40517 ops/sec (±8.30%) 43839 ops/sec (±6.81%) 1.08
abiDecode 28637 ops/sec (±7.65%) 30836 ops/sec (±5.71%) 1.08
sign 1511 ops/sec (±0.83%) 1545 ops/sec (±3.43%) 1.02
verify 354 ops/sec (±0.73%) 370 ops/sec (±0.49%) 1.05

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Sep 17, 2024

Benchmark

Benchmark suite Current: 8c0bbc1 Previous: a21078b Ratio
processingTx 22385 ops/sec (±7.24%) 22494 ops/sec (±8.39%) 1.00
processingContractDeploy 38514 ops/sec (±7.96%) 38470 ops/sec (±7.11%) 1.00
processingContractMethodSend 15946 ops/sec (±7.70%) 16121 ops/sec (±6.53%) 1.01
processingContractMethodCall 27112 ops/sec (±7.56%) 28342 ops/sec (±6.29%) 1.05
abiEncode 44094 ops/sec (±6.80%) 43839 ops/sec (±6.81%) 0.99
abiDecode 31351 ops/sec (±7.28%) 30836 ops/sec (±5.71%) 0.98
sign 1563 ops/sec (±0.72%) 1545 ops/sec (±3.43%) 0.99
verify 365 ops/sec (±2.51%) 370 ops/sec (±0.49%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

cloudflare-workers-and-pages bot commented Sep 17, 2024

Deploying web3-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0799331
Status: ✅  Deploy successful!
Preview URL: https://d28d0b27.web3-js-docs.pages.dev
Branch Preview URL: https://head.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Sep 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.43%. Comparing base (a21078b) to head (0799331).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7264   +/-   ##
=======================================
  Coverage   94.43%   94.43%           
=======================================
  Files         216      216           
  Lines        8463     8463           
  Branches     2338     2338           
=======================================
  Hits         7992     7992           
  Misses        471      471           
Flag Coverage Δ
UnitTests 94.43% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

CHANGELOG.md Outdated Show resolved Hide resolved
@jdevcs
Copy link
Contributor

jdevcs commented Sep 18, 2024

@luu-alex pls also include web3-types pkg in this release as it was not in last hot fix

@luu-alex luu-alex merged commit 5a7e302 into 4.x Sep 18, 2024
84 of 88 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants