Ankr provider #7260
Draft
Ankr provider #7260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
![github-actions[bot]](https://github.com/avatars/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Benchmark
| Benchmark suite | Current: de19a1a | Previous: b3cb1b7 | Ratio |
|---|---|---|---|
processingTx |
22231 ops/sec (±7.51%) |
21696 ops/sec (±8.85%) |
0.98 |
processingContractDeploy |
38595 ops/sec (±5.39%) |
40328 ops/sec (±6.93%) |
1.04 |
processingContractMethodSend |
14873 ops/sec (±8.76%) |
17416 ops/sec (±6.78%) |
1.17 |
processingContractMethodCall |
27671 ops/sec (±6.83%) |
28028 ops/sec (±7.80%) |
1.01 |
abiEncode |
42136 ops/sec (±7.57%) |
46457 ops/sec (±6.59%) |
1.10 |
abiDecode |
29800 ops/sec (±8.23%) |
31537 ops/sec (±7.34%) |
1.06 |
sign |
1533 ops/sec (±0.85%) |
1584 ops/sec (±0.53%) |
1.03 |
verify |
353 ops/sec (±3.12%) |
364 ops/sec (±2.47%) |
1.03 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7260 +/- ##
=======================================
Coverage 94.44% 94.44%
=======================================
Files 216 216
Lines 8454 8454
Branches 2335 2335
=======================================
Hits 7984 7984
Misses 470 470
Flags with carried forward coverage won't be shown. Click here to find out more. |
jdevcs
commented
Sep 17, 2024
| @@ -46,8 +46,20 @@ describe('Web3 RPC Provider Integration tests', () => { | |||
| web3.provider?.disconnect(); | |||
| } | |||
| }); | |||
|
|
|||
| if (transport !== Transport.WebSocket) { | |||
| it.skip(`AnkrProvider should work with ${transport} transport and ${network} network`, async () => { | |||
There was a problem hiding this comment.
skipped as key not added yet
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#6974
#7263
Type of change
Checklist:
npm run lintwith success and extended the tests and types if necessary.npm run test:unitwith success.npm run test:coverageand my test cases cover all the lines and branches of the added code.npm run buildand testeddist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.