Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle common cases for smart contract errors according to EIP 838 #7155

Conversation

Muhammad-Altabba
Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba commented Jul 16, 2024

Closes #7237

Copy link

github-actions bot commented Jul 16, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.17 kB → 639.51 kB (+349 B) +0.05%
Changeset
File Δ Size
../web3-eth-abi/lib/commonjs/decode_contract_error_data.js 📈 +1.13 kB (+56.74%) 1.99 kB → 3.12 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 619.88 kB → 620.22 kB (+349 B) +0.05%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: d446964 Previous: 9b32205 Ratio
processingTx 21376 ops/sec (±7.86%) 23392 ops/sec (±7.52%) 1.09
processingContractDeploy 40745 ops/sec (±5.11%) 40479 ops/sec (±6.69%) 0.99
processingContractMethodSend 16087 ops/sec (±6.32%) 16317 ops/sec (±6.87%) 1.01
processingContractMethodCall 28265 ops/sec (±6.58%) 27614 ops/sec (±8.40%) 0.98
abiEncode 43812 ops/sec (±6.76%) 46686 ops/sec (±6.17%) 1.07
abiDecode 31323 ops/sec (±5.88%) 31121 ops/sec (±7.84%) 0.99
sign 1523 ops/sec (±3.75%) 1556 ops/sec (±0.91%) 1.02
verify 366 ops/sec (±0.54%) 369 ops/sec (±0.48%) 1.01

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Jul 16, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 94.48%. Comparing base (9b32205) to head (d446964).

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7155      +/-   ##
==========================================
- Coverage   94.50%   94.48%   -0.02%     
==========================================
  Files         216      216              
  Lines        8429     8439      +10     
  Branches     2315     2318       +3     
==========================================
+ Hits         7966     7974       +8     
- Misses        463      465       +2     
Flag Coverage Δ
UnitTests 94.48% <80.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

@luu-alex
Copy link
Contributor

Looks good, update changelog

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Muhammad-Altabba pls add changelog before merging , thanks

@Muhammad-Altabba Muhammad-Altabba merged commit 7a6e492 into 4.x Sep 5, 2024
53 of 54 checks passed
@Muhammad-Altabba Muhammad-Altabba deleted the 7143-an-issue-when-calling-a-method-on-diamonds-proxy-contract branch September 5, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants