Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix waitingforreceipt error #7098

Merged
merged 8 commits into from
Jun 25, 2024
Merged

fix waitingforreceipt error #7098

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c960229
fix waitingforreceipt error
Jun 12, 2024
f4f9060
update cach
Jun 13, 2024
9691e9b
remove comment
Jun 17, 2024
1f6aed5
Merge branch '4.x' into fix-waitingforreceipt-error
Jun 17, 2024
6885888
throw other errors
Jun 19, 2024
434538c
update changelog and text
Jun 19, 2024
03c36a7
Merge branch '4.x' into fix-waitingforreceipt-error
Jun 19, 2024
60a6a8c
update linter
Jun 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions packages/web3-eth/src/rpc_method_wrappers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,11 +496,16 @@
transactionHash,
DEFAULT_RETURN_FORMAT,
);
const response = await ethRpcMethods.getTransactionReceipt(
web3Context.requestManager,
transactionHashFormatted,
);

let response;
try {
response = await ethRpcMethods.getTransactionReceipt(
web3Context.requestManager,
transactionHashFormatted,
);
} catch (error) {
console.warn(error)

Check warning on line 506 in packages/web3-eth/src/rpc_method_wrappers.ts

View check run for this annotation

Codecov / codecov/patch

packages/web3-eth/src/rpc_method_wrappers.ts#L506 

Added line #L506 was not covered by tests
luu-alex marked this conversation as resolved.
Show resolved Hide resolved
}

return isNullish(response)
? response
: (format(
Expand Down
3 changes: 1 addition & 2 deletions packages/web3-eth/src/web3_eth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -943,9 +943,8 @@ export class Web3Eth extends Web3Context<Web3EthExecutionAPI, RegisteredSubscrip
transactionHash,
returnFormat,
);

if (!response) throw new TransactionNotFound();

return response;
}

Expand Down
Loading