Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EIP6963 web3 provider update event #6855

Merged
merged 9 commits into from
Mar 5, 2024
Merged

EIP6963 web3 provider update event #6855

merged 9 commits into from
Mar 5, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Mar 4, 2024

Description

Related with: #6201
#6859
now requestEIP6963Providers return promise resolving to Map<string, EIP6963ProviderDetail> containing providers list, and it will emit web3:providersMapUpdated event for any update to above map obj

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

@jdevcs jdevcs marked this pull request as ready for review March 4, 2024 18:16
Copy link

github-actions bot commented Mar 4, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 621.63 kB → 622.91 kB (+1.27 kB) +0.21%
Changeset
File Δ Size
src/web3_eip6963.ts 📈 +1.44 kB (+87.20%) 1.65 kB → 3.09 kB
src/web3.ts 📈 +74 B (+0.91%) 7.91 kB → 7.98 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 603.05 kB → 603.9 kB (+867 B) +0.14%
../lib/commonjs/web3_eip6963.d.ts 922 B → 1.2 kB (+310 B) +33.62%
../lib/commonjs/web3.d.ts 1.26 kB → 1.35 kB (+93 B) +7.23%
../lib/commonjs/providers.exports.d.ts 148 B → 183 B (+35 B) +23.65%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.63 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.45 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

github-actions bot commented Mar 4, 2024

Benchmark

Benchmark suite Current: 91948c2 Previous: 6c075db Ratio
processingTx 9581 ops/sec (±4.09%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 42925 ops/sec (±7.13%) 39129 ops/sec (±7.62%) 0.91
processingContractMethodSend 20810 ops/sec (±6.40%) 19443 ops/sec (±5.19%) 0.93
processingContractMethodCall 41184 ops/sec (±5.68%) 38971 ops/sec (±6.34%) 0.95
abiEncode 46384 ops/sec (±7.36%) 44252 ops/sec (±6.92%) 0.95
abiDecode 32230 ops/sec (±7.63%) 30419 ops/sec (±8.89%) 0.94
sign 1662 ops/sec (±3.87%) 1656 ops/sec (±4.08%) 1.00
verify 375 ops/sec (±0.48%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

Merging #6855 (91948c2) into 4.x (0e59f28) will increase coverage by 0.00%.
Report is 1 commits behind head on 4.x.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6855   +/-   ##
=======================================
  Coverage   92.06%   92.07%           
=======================================
  Files         215      215           
  Lines        8212     8222   +10     
  Branches     2208     2209    +1     
=======================================
+ Hits         7560     7570   +10     
  Misses        652      652           
Flag Coverage Δ
UnitTests 92.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants