Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable users to provide feedback page #6815

Merged
merged 4 commits into from
Feb 19, 2024
Merged

Conversation

SantiagoDevRel
Copy link
Member

Created page in the docs for users to provide feedback, linked it to the google form

#6738

Copy link

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 0 619 KB 619 KB -
View detailed bundle breakdown

Added

Asset Old size New size Diff Diff %
web3.min.js 0 601 KB 601 KB -
../lib/commonjs/index.d.ts 0 8.63 KB 8.63 KB -
../lib/commonjs/accounts.d.ts 0 3.89 KB 3.89 KB -
../lib/commonjs/types.d.ts 0 2.45 KB 2.45 KB -
../lib/commonjs/web3.d.ts 0 1.14 KB 1.14 KB -
../lib/commonjs/abi.d.ts 0 999 bytes 999 bytes -
../lib/commonjs/eth.exports.d.ts 0 280 bytes 280 bytes -
../lib/commonjs/providers.exports.d.ts 0 148 bytes 148 bytes -
../lib/commonjs/version.d.ts 0 60 bytes 60 bytes -

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

No assets were unchanged

Copy link

github-actions bot commented Feb 15, 2024

Benchmark

Benchmark suite Current: 833ffe1 Previous: 6c075db Ratio
processingTx 9600 ops/sec (±4.37%) 9301 ops/sec (±4.81%) 0.97
processingContractDeploy 41320 ops/sec (±6.72%) 39129 ops/sec (±7.62%) 0.95
processingContractMethodSend 20764 ops/sec (±6.87%) 19443 ops/sec (±5.19%) 0.94
processingContractMethodCall 40779 ops/sec (±5.90%) 38971 ops/sec (±6.34%) 0.96
abiEncode 47200 ops/sec (±7.05%) 44252 ops/sec (±6.92%) 0.94
abiDecode 31902 ops/sec (±9.12%) 30419 ops/sec (±8.89%) 0.95
sign 1688 ops/sec (±0.90%) 1656 ops/sec (±4.08%) 0.98
verify 376 ops/sec (±1.00%) 373 ops/sec (±0.78%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Merging #6815 (833ffe1) into 4.x (4358140) will increase coverage by 4.65%.
Report is 177 commits behind head on 4.x.
The diff coverage is 95.84%.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6815      +/-   ##
==========================================
+ Coverage   87.37%   92.02%   +4.65%     
==========================================
  Files         197      214      +17     
  Lines        7548     8179     +631     
  Branches     2059     2201     +142     
==========================================
+ Hits         6595     7527     +932     
+ Misses        953      652     -301     
Flag Coverage Δ
UnitTests 92.02% <95.84%> (+4.65%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@SantiagoDevRel SantiagoDevRel merged commit c5cecaf into 4.x Feb 19, 2024
51 of 53 checks passed
@SantiagoDevRel SantiagoDevRel deleted the enable-user-feedback-6738 branch February 19, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants