Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add attribution for faster bytesToHex implementation #6646

Closed
wants to merge 2 commits into from

Conversation

mpetrunic
Copy link
Contributor

related to #6596 (comment)

Copy link

github-actions bot commented Dec 7, 2023

Bundle Stats

Hey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Asset Old size New size Diff Diff %
Total 590 KB 590 KB 0 0.00%
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset Old size New size Diff Diff %
web3.min.js 572 KB 572 KB 0 0.00%
../lib/commonjs/index.d.ts 8.63 KB 8.63 KB 0 0.00%
../lib/commonjs/accounts.d.ts 3.89 KB 3.89 KB 0 0.00%
../lib/commonjs/types.d.ts 2.45 KB 2.45 KB 0 0.00%
../lib/commonjs/web3.d.ts 1.14 KB 1.14 KB 0 0.00%
../lib/commonjs/abi.d.ts 1000 bytes 1000 bytes 0 0.00%
../lib/commonjs/eth.exports.d.ts 280 bytes 280 bytes 0 0.00%
../lib/commonjs/providers.exports.d.ts 148 bytes 148 bytes 0 0.00%
../lib/commonjs/version.d.ts 60 bytes 60 bytes 0 0.00%

Copy link

cloudflare-workers-and-pages bot commented Dec 7, 2023

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 0d9bd8b
Status: ✅  Deploy successful!
Preview URL: https://0a298560.web3-js-docs.pages.dev
Branch Preview URL: https://mpetrunic-patch-1.web3-js-docs.pages.dev

View logs

Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #6646 (2dc0dc2) into 4.x (f1c6916) will not change coverage.
Report is 46 commits behind head on 4.x.
The diff coverage is n/a.

❗ Current head 2dc0dc2 differs from pull request most recent head 0d9bd8b. Consider uploading reports for the commit 0d9bd8b to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #6646   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files         214      214           
  Lines        8114     8114           
  Branches     2169     2169           
=======================================
  Hits         7369     7369           
  Misses        745      745           
Flag Coverage Δ
UnitTests 90.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

Copy link
Contributor

@Muhammad-Altabba Muhammad-Altabba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!
But I suggest that only the code origin (@noble/hashes) need to be mentioned. If you think so.

And also I had a small suggestion that is to mention that the code was further enhanced. So, other developers can take the enhanced version and then mention that they took the code from web3 and the original @noble/hashes.

Co-authored-by: Muhammad Altabba <24407834+Muhammad-Altabba@users.noreply.github.com>
Copy link

This PR has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

@github-actions github-actions bot added the Stale Has not received enough activity label Feb 11, 2024
@github-actions github-actions bot closed this Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Has not received enough activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants