-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add web3-eth-account guide #6617
Conversation
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded
Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged No assets were unchanged |
Deploying with Cloudflare Pages
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## 4.x #6617 +/- ##
==========================================
+ Coverage 89.36% 90.39% +1.03%
==========================================
Files 215 215
Lines 8309 8322 +13
Branches 2248 2247 -1
==========================================
+ Hits 7425 7523 +98
+ Misses 884 799 -85
Flags with carried forward coverage won't be shown. Click here to find out more.
|
docs/docs/guides/wallet/index.md
Outdated
} | ||
|
||
``` | ||
### import a private key and sign a transaction with the web3 package |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also add example of contract using local web3 wallet for implicitly signing a tx for .send()
@luu-alex
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have few requests, please.
approving, you may merge PR after addressing feedback, thanks |
Description
#6258
doc includes:
replaced some privatekeys in docs to a place header
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.